Repository navigation
fix(pm-stack): retire sandbox collector drill units - #5334
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41a8b01d8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| HOST="$(hostname -s)" | ||
| [ "$HOST" = "amd" ] || die "must run on laptop host 'amd'; refusing on '$HOST'" |
There was a problem hiding this comment.
Target the laptop collector's user service manager
On the documented NixOS laptop deployment, the collector is declared under systemd.user.services and systemd.user.timers in nixos/services/pm-stack/default.nix, but this now laptop-only script still uses plain systemctl is-active and sudo -n systemctl for collector operations. Those address the system manager, so the drill refuses at its inactive-timer precondition even when the laptop's collector user timer is running. Local systemctl --help confirms that --user means “Connect to user service manager.” Migrate the check, stop, and restoration commands to systemctl --user without sudo alongside this host restriction.
Useful? React with 👍 / 👎.
|
🤖 Agent note · follow-up review disposition (task 9309, direct lane code-h) Review follow-up on this PR (from task 9250's cursor review of PR #5334), dispositioned against fresh state 2026-11-04: CI — the failing check is pre-existing on Packet defect (a) — StackChanIcecream.md: not a defect of this PR. Packet defect (b) — single-source schedule doc: the PR's approach is consistent. Diff soundness (spot-verified): systemd service/timer deleted, drill script gains an Disposition: no change requested from task 9309. The merge decision stays with the owning task 6566, with the CI picture above (only failure = pre-existing, tracked by issue #5364). Task 9309 completes as |
|
🤖 Agent note · CORRECTION to the task 9309 disposition above The task 9309 note (comment 6628092466) stated Codex review completed with no findings. That was wrong — it rested on a review-state reading that belonged to a different PR. Fresh verification just now:
Per the fleet Codex gate, this finding is UNDISPOSITIONED and blocks merge until the owning task (task 6566) fixes it in the PR or replies on the thread why not. The rest of the task 9309 disposition stands (CI failure = pre-existing health-inbox tests, issue #5364; packet defects (a)/(b) as recorded). Task 9309's own completion state in the queue is separately unverified due to the ongoing Supabase outage; this correction is posted on GitHub, which is reachable, so the gate information is not hostage to the queue. |
Part of #1319.
Summary
/home/hatch/git/pm-feedcheckout.amd; cover the refusal with a test.Verification
bun test test/kill-collector-drill.test.ts— 8 pass, 0 fail.git diff --check— pass.Out-of-repo sandbox audit
This PR does not inspect or change the sandbox host itself. After its next recycle, run there and attach the results to #1319:
Verify no fleet server unit is enabled/running and no unexpected fleet listener is present. Keep #1319 open until this host-level audit confirms the boot path.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.