Skip to content

docs(registry): record complete systemd timer cadences in Surface 2b - #5340

Merged
dezren39 merged 1 commit into
mainfrom
queue/9317-5313-timer-cadences
Nov 4, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/9317-5313-timer-cadences

Conversation

@dezren39

@dezren39 dezren39 commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Summary

Surface 2b of doc/fleet-schedule-registry.md recorded most systemd timer cadences as OnCalendar=*-*-*, which systemd normalizes to daily at midnight — misstating every-minute, hourly, and 15-minute timers in the registry the placement audit reads.

Fixes #5313

Changes (docs only, one file)

  • Re-read every Surface 2b row against live systemctl --user show TimersCalendar/TimersMonotonic on the laptop and recorded the complete effective calendar expression (date + time) for all 33 calendar rows — e.g. laptop-autocommit-*.timer → *-*-* *:*:00 (every minute), worktree-reaper.timer → *-*-* *:00:00 (hourly), quota-gatherer.timer → *-*-* *:00/15:00 (every 15 min). The 6 monotonic rows were already complete and are unchanged apart from the review date.
  • pm-digest-daily.timer / pm-digest-weekly.timer are not loaded on the laptop; verified against nixos/services/pm-stack/default.nix instead (*-*-* 07:00:00, Mon *-*-* 07:05:00).
  • Maintenance rule + Surface 2b intro + Verification note now require preserving the complete effective calendar specification on future refreshes, and record this re-verification (queue task 9317).
  • Last-review dates on the re-verified rows refreshed to 2026-11-04.

No timer configuration or source unit definition changed.

Verification

  • Live systemctl --user show for all 39 listed timers captured this run; each row's new spec matches the live TimersCalendar value (or the Nix source for the two pm-digest timers).
  • Diff limited to doc/fleet-schedule-registry.md. Note: prettier --check fails identically on the unmodified file on main, so the table was hand-padded in the file's existing style rather than reformatting unrelated surfaces.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Documentation
    • Updated the fleet registry with complete calendar specifications for all 37 timers and revised review dates.
    • Recorded verification of two unloaded timers and clarified that timer entries must include date and time components.

@dezren39
dezren39 requested a review from a team as a code owner November 4, 2026 07:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T07:37:08.370900Z d80e424 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The fleet schedule registry now records complete effective calendar expressions for all 37 systemd timers. It updates the review dates to 2026-11-04 and documents the re-verification, including checks against Nix configuration for two unloaded timers.

Changes: Fleet timer registry

Layer / File(s) Summary
Calendar cadence records
doc/fleet-schedule-registry.md
The guidance now requires complete effective calendar expressions and notes that *-*-* means daily at midnight. All 37 timer rows have updated cadence records and review dates. The verification note records live checks, with two unloaded timers checked against Nix configuration.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other · Severity of issue fixed: Medium

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to d80e4

This documentation-only update presents no identified merge-blocking risk and is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the documentation change: recording complete systemd timer cadences in Surface 2b.
Linked Issues check Passed [#5313] The requirement is a documentation change to doc/fleet-schedule-registry.md. The whole-PR diff (merge base to head) changes the Surface 2b cadence specs for the 33 calendar rows to full expres…
Out of Scope Changes check Passed [#5313] The whole-PR diff touches only doc/fleet-schedule-registry.md. Every hunk supports the issue. The hunks update the cadence spec cells in section 2b, add the complete-spec maintenance rule and …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

[#5313] The requirement is a documentation change to doc/fleet-schedule-registry.md. The whole-PR diff (merge base to head) changes the Surface 2b cadence specs for the 33 calendar rows to full expressions with date and time parts, for example *-*-* *:*:00, *-*-* *:00:00, and *-*-* *:00/15:00. The 6 monotonic rows keep their existing specs. The diff also adds a maintenance rule requiring complete calendar specs, updates the Surface 2b intro, and adds a verification note. The 2b review dates are refreshed to 2026-11-04. The laptop-autocommit rows match Timer.OnCalendar = "*-*-* *:*:00" in nixos/home/laptop-autocommit.nix. The issue acceptance criteria are met on the visible evidence. Limits: I could not run systemctl --user show, so the live values for the remaining rows rest on the author's stated capture. The pm-digest-daily and pm-digest-weekly specs (*-*-* 07:00:00, Mon *-*-* 07:05:00) were not confirmed, because the timer section of nixos/services/pm-stack/default.nix fell outside the read. Also, the 2b heading still says "(37 timers)" while the table lists 39 rows. This mismatch predates the PR and does not affect the issue's requirements.

Full details: Out of Scope Changes check

Explanation

[#5313] The whole-PR diff touches only doc/fleet-schedule-registry.md. Every hunk supports the issue. The hunks update the cadence spec cells in section 2b, add the complete-spec maintenance rule and the 2b intro wording, add the verification note, and refresh the last-review dates on the re-verified rows. No timer configuration or Nix unit definition changed. The table is re-padded to fit the wider spec column, which is a formatting effect of the in-scope change. No unrelated change was found.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c6c712e-7957-4d04-a04e-2d0da46c01c3
Commits

Reviewing files that changed from the base of the PR and between 9ece76e and d80e424.

Files selected for processing: 1
  • doc/fleet-schedule-registry.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fleet-schedule-registry: systemd timer rows drop the OnCalendar time component — every-minute/hourly timers read as daily at midnight

1 participant