Repository navigation
fix(fleet-config): reject unknown fleet.toml sections/keys instead of silently using defaults (#5460) - #5462
Merged
Conversation
![developing-today[bot]](https://s.lequ.pw/_assets/images/gravatars/gravatar-user-420.png){kind=avatar}
… silently using defaults (#5460)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5460.
fleet-configparsedfleet.tomlwith serde's default unknown-field handling, so a misspelled section or key silently fell back to the compiled-in defaults — a typo'd[domain]table left the domain the operator meant to disable (the §7 incident lever) enabled, contradicting the crate doc's "a malformed file is a loud error, never a silent fallback" contract.Change (
pkgs/fleet/crates/fleet-config/src/lib.rsonly):#[serde(deny_unknown_fields)]onConfig,ProxyConfig, andSecretsConfig, so unknown sections/keys surface asConfigError::Parsenaming the field.[domains]stays an open map — the deny applies to struct fields, not domain names.unknown_section_or_key_is_a_loud_errorcovers a misspelled section, three misspelled keys, and an unknown top-level key;domains_stays_an_open_mappins arbitrary domain names).Verification:
cargo test -p fleet-configon the laptop — 6 passed (4 pre-existing + 2 new). Pre-filing probe (real crate as a path dependency,~/git/fleet/probe-fleetconfigon the laptop) showed all three misspelling shapes loadingOkwith defaults before the fix.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.