[dezren39]

Fixes #5575.

fleet proxy serve discarded every trailing argument: run_proxy's serve branch dispatched straight to fleet_proxy::serve::run(config) — a config-only entry point — so fleet proxy serve --help, fleet proxy serve --bogus-junk, and the argv0 form laptop-agent-broker --help all bound the broker socket and served instead of printing help or erroring. Same bug class as #5488 (fleet serve <role> --help) and #5560 (fleet dispatch status), on the one leaf those fixes didn't reach.

Change (pkgs/fleet/crates/fleet/src/main.rs only)

• New classify_proxy_serve_args gate in run_proxy's serve branch, before anything binds:
  • any help flag in the tail (--help / -h / help) → print PROXY_SERVE_USAGE, exit 0;
  • any other trailing argument → usage error, exit 2;
  • bare tail → run the broker exactly as today.
• New unit test proxy_serve_args_classify_help_and_reject_strays pins all three shapes, including help-wins-anywhere (mirroring verb_status from fleet dispatch status silently ignores all arguments — --help performs a live GET /health and typos are swallowed #5560) and the implied-arg argv0 route.

Verification (laptop)

• cargo test -p fleet green: 3 passed (incl. the new pin; fmt applied).
• Fixed binary re-probed with a fake HOME and temp FLEET_BROKER_SOCKET:
  • proxy serve --help → usage, exit 0, no socket file created;
  • proxy serve --bogus-junk → usage error, exit 2, no socket file created;
  • laptop-agent-broker --help → usage, exit 0;
  • bare proxy serve → still binds and serves (timeout-killed, 124).
• Pre-fix probe of the same shapes is recorded on fleet: proxy serve --help (and any trailing argument) silently starts the session-proxy daemon #5575 (all three bound and served).

---

^{Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-04T16:23:54.994823Z	fe22677	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: c8f857d9-e571-4dd8-b6ed-bc3b1a6b9510

Commits

Reviewing files that changed from the base of the PR and between 4d2eeec and fe22677.

Files selected for processing: 1

• pkgs/fleet/crates/fleet/src/main.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn