Skip to content

fix(home): correct proxy ownership comments - #6113

Open
dezren39 wants to merge 5 commits into
mainfrom
queue/8983-2775-proxy-comment-cleanup
Open

dezren39 wants to merge 5 commits into
mainfrom
queue/8983-2775-proxy-comment-cleanup

Conversation

@dezren39

@dezren39 dezren39 commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Summary

- proxy-supervisor owns the live proxy units; agy-proxy is ordered after
+ Home Manager owns the per-proxy units; drop the obsolete agy-proxy ordering edge
- endpoint.json has no writer after supervisor retirement
+ proxy processes still publish endpoint.json; supervisor reconciliation is retired

Refs #2775.

Evidence

  • Before: stale ownership/endpoint comments and an After entry for the retired agy-proxy.service.
    After: corrected comments and removed only that obsolete ordering entry; valid ordering remains.
  • git diff --check — pass
  • nix-instantiate --parse home/openclaw/default.nix — pass
  • nix-instantiate --parse home/common/default.nix — pass
  • nix eval --raw .#nixosConfigurations.amd.config.home-manager.users.user.home.activationPackage.drvPath — pass

Merge Danger

Door: two-way; the comments and obsolete ordering reference can be reverted directly.

Blast Radius: low; no proxy lifecycle behavior changed.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 5, 2026 07:14
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dffb252d-4f55-4d1a-9ee1-18bcfe41d80c
Commits

Reviewing files that changed from the base of the PR and between e3626d1 and e532ffa.

Files selected for processing: 2

  • home/common/default.nix
  • home/openclaw/default.nix
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T09:33:44.364487Z e532ffa New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant