Repository navigation
Conversation
![developing-today[bot]](https://s.lequ.pw/_assets/images/gravatars/gravatar-user-420.png){kind=avatar}
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep-only PR for #1943 (mcpx docs custom domain), opened by the 2026-11-05 unblock pass.
What this does: declares
"mcpx" = "developing-today.github.io"ininfra/dns/dns_config/default.nix(developing-today.com zone), following the workingzettelpattern in the same block.What this does NOT do: nothing is applied. No terraform apply, no DNS change, no Pages change. Per #1860, Porkbun terraform applies need Drew's explicit go-ahead.
Still missing by design: the
_github-pages-challenge-developing-today.mcpxTXT record — its token only exists after the GitHub Pages claim step (setting the custom domain on this repo), so it lands in the cutover change, not this prep.Cutover sequence once Drew says go (all agent-executed): 1) set Pages custom domain
mcpx.developing-today.comvia gh api and read the challenge token; 2) add the TXT record to this file, apply this PR's terraform; 3) verify dig + domain verification + HTTPS cert, then flip the docs workflow siteUrl to/; 4) Porkbun URL-forwardmcpx.developing.today→https://mcpx.developing-today.com(console step in the same authorization).Drew's remaining input is exactly: (1) confirm canonical = mcpx.developing-today.com with mcpx.developing.today as redirect (the only shape Pages supports), (2) the apply go-ahead.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.