Repository navigation
fix(opencode-claimant): raise the claimant binding rate (#6257) - #6263
Merged
Merged
Conversation
… parallel launches, live-fire cadence The standing claimant never bound tasks: its mode file stayed on shadow (a slice-1 gate whose parallel-run packet never landed), the only binds were ad-hoc agent drives, and the 12-session server-wide cap left cap_room ~0-2. Diagnosis + before-metrics: #6257. - claimant.py: commit the deterministic executor (it existed only as an untracked file in the laptop primary checkout). Add the shadow-mode gate its docstring always promised (Step 4 launched unconditionally), a single-instance flock, and a bounded parallel launch pool (4 workers) across distinct candidates - exactly-once stays anchored on the atomic DB bind, skips backfill. - poll.py + claimant.py + prompt.md: concurrency cap 12 -> 20 (census headroom: 18-19 roots at load 4.5-7.5/16 cores). - prompt.md: EXECUTION section - a fire executes claimant.py deterministically instead of improvising prompt.md by hand. - install.mjs: fire cadence */10 -> */5. - README.md: cap + cadence constants aligned. Tests: install.test.mjs 13/13 pass. test_poll.py 35/36 - the one failure (test_unknown_active_set_fails_closed) fails identically on pristine origin/main; pre-existing, untouched here.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the claimant binding rate diagnosed in #6257 (Drew: "fix it", 2026-11-05).
Root causes (all measured, two reads each): the standing claimant fires on schedule but its mode file is
shadow, so it launches nothing - every bind since 2026-11-04 came from ad-hoc agent drives (29 binds, then 0 in the 6h before the fix while 26-43 candidates waited). The 12-session server-wide cap left cap_room at 0-2. And the deterministic executor, claimant.py, was never committed - it lived untracked in the laptop primary, so the fleet kept running the LLM-prompt form of the claimant.Changes
claimant.pycommitted (pre-existing implementation, previously untracked) with three fixes: the shadow-mode gate its own docstring promised (Step 4 previously launched unconditionally - the scheduled task never ran it directly, which is the only reason that stayed latent), a single-instance flock so overlapping fires can never race a candidate list, and a bounded parallel launch pool (4 workers) across distinct candidates. Exactly-once stays anchored on the atomic DB bind (bind_repo_task_lane_session); each worker re-verifies its candidate, and a failed bind/prompt deletes the created session (previous behavior). Skips backfill without consuming cap room, as the serial loop did.Smoke test (shadow, pre-merge): patched claimant.py run end-to-end - 26 candidates discovered, 0 launched, skip recorded as
shadow mode: no launches, cap_room 17 at cap 20, inflight log untouched.Tests:
bun test test/install.test.mjs13/13.python3 -m unittest test_poll35/36 -test_unknown_active_set_fails_closedfails identically on pristine origin/main (verified), pre-existing and unrelated.Rollout after merge: reinstall the OpenChamber task from the primary (--enable), move the primary's untracked claimant.py aside, pull, flip the mode file to
live, and verify on #6257 (candidate drain, time-to-bind, double-bind audit).Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.