Repository navigation
fix(pm-apps): point ready-for-agent tailnet proxy at the systemd package socket-proxyd (#1181) - #6453
Merged
Merged
Conversation
…age socket-proxyd (#1181)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken tailnet leg of #1181.
Problem
ready-for-agent-tailnet.service(the socket-activated proxy that serves ready-for-agent on the tailnet address 100.99.113.103:6056) had:That path does not exist on this host (
/run/current-system/sw/bin/contains onlyvirtproxyd), so the service died with 203/EXEC on the first real connection and start-limit-failed both units. The socket sat armed and looked healthy until anyone actually connected. Verified live 2026-11-06 (see the deploy-verification comment on #1181).Fix
One line in
nixos/services/pm-apps/default.nix: reference the binary from the systemd package actually deployed by this configuration —(The module's args are
{ config, lib, ... }— nopkgsin scope — andconfig.systemd.packageis the authoritative reference to the deployed systemd build.)Verification
nix evalon this branch:config.systemd.package→/nix/store/6qqq5prql4952z0wfm5ymjfr7cx4ab7z-systemd-262home-manager.users.user.systemd.user.services.ready-for-agent-tailnet.Service.ExecStart→"/nix/store/6qqq5prql4952z0wfm5ymjfr7cx4ab7z-systemd-262/lib/systemd/systemd-socket-proxyd 127.0.0.1:6056"-r-xr-xr-x … systemd-socket-proxyd).Post-merge:
nixos-rebuild switch+ the #1181 verification steps (real curl to 100.99.113.103:6056 must return 200) before #1181 closes.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.