Repository navigation
Conversation
![developing-today[bot]](https://s.lequ.pw/_assets/images/gravatars/gravatar-user-420.png){kind=avatar}
sign_genesis returns SignError::NotAPlayer for a key that is neither seat. sign_claim now takes the agreement and refuses non-player signers (NotAPlayer) and claims answering another agreement (AgreementMismatch); the bare path is crate-private sign_claim_unchecked. Also fixes two str/String comparisons in world_net.rs that stop the id lib compiling on current main.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6424. Phase 2 of design #6487.
sign_genesisreturnsSignError::NotAPlayerwhen the signing key is neither seat.sign_claimnow takes theGenesisAgreement; refuses non-player signers (NotAPlayer) and claims answering another agreement (AgreementMismatch). The bare path is crate-privatesign_claim_unchecked(artifactsign_uncheckedpattern).compute_stateunchanged.tests/attestation_signer_player.rs(4); existing attestation tests updated for the new signature. 20 attestation tests pass locally.strvsStringcomparisons inworld_net.rs(lines 658, 1621) that stopped theidlib compiling on main9c06d0c8a4(rustc 1.99.0). Unrelated to the issue; included so tests can build.Queue task 10870.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.