Repository navigation
fix(id): repair records-budget WIP swept in by repo-keeper snapshot e756e67d58 - #6570
Merged
Merged
Conversation
![developing-today[bot]](https://s.lequ.pw/_assets/images/gravatars/gravatar-user-420.png){kind=avatar}
…ot (e756e67) The snapshot landed RecordsBudget half-finished: two str/String comparison type errors (validate_record ordering check, record_pages cursor-advance check) broke the crate build, and record_pages returned before pushing its final page, silently dropping that page's records (paged_records_survive_the_iroh_frame_limit: 95 of 96). - Compare keys as &str on both sides (String ordering is str ordering; the stated invariants are unchanged). - Run the cursor validations against the page, then push it, then branch on next_after -- the final page is retained. - rustfmt the snapshot's additions. Diagnosis and switch-block context: code#5218.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Repo-keeper snapshot commit
e756e67d58("repo-keeper: snapshot code 2026-11-06 08:24 CST") swept a half-finished RecordsBudget WIP feature into main. On current main theidlib-test target did not compile, and once compiling, the WIP dropped data:pkgs/id/src/world_net.rs:key > last—&strcompared against&Stringnext > cursor—&strcompared against&Stringrecord_pages: the snapshot had movedpages.push(...)below thematch, so thenext_after: Nonearm returnedOk(pages)before pushing the final page — silently dropping it. The WIP's own test caught it once the code compiled:paged_records_survive_the_iroh_frame_limitgot 95 of 96 records.Oracle reasoning
The code's own stated invariants are string-ordering checks ("keys must be strictly ascending"; "records cursor did not advance").
Stringordering isstrordering, so comparing the borrowed values as&stris the faithful fix — no semantics change, no assertion weakened. Forrecord_pages, the fix runs the cursor validations against the borrowed page, then pushes, then branches onnext_after— every WIP validation is preserved; only the push ordering is repaired.Verification
paged_records_survive_the_iroh_frame_limitPASS;test_clear_spanning_more_authors_than_the_cap_clears_exactly_its_claimsPASS.cargo test -p id --lib→ 2305 passed; 0 failed; 6 ignored.cargo fmtapplied; blast radius confined topkgs/id/src/world_net.rs(46 insertions / 45 deletions).Context: this unblocks the check phase that stopped the 2026-11-04 Mistral deploy switch (code#5218). The original red test from that switch was already repaired separately by #5736 (role-aware default view); this PR fixes the successor blocker that landed on main this morning.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.