[dezren39]

Fixes #654

Problem

PR #648 (#639) re-attached the empty ?/# markers as a suffix after every geturl() rebuild. When the query is empty and the fragment is non-empty, the ? therefore landed after the fragment: http://example.com/path?#frag came back as http://example.com/path#frag? — a different URL (fragment corrupted to frag?, empty query absent) than the Worker returns, on the plain, percent-decoded-host and canonical-IP return paths alike.

Solution

• New _attach_empty_query_fragment_markers(rebuilt, source_url) helper: the empty-query marker is inserted before the # that introduces a non-empty fragment in the rebuilt URL; the empty-fragment marker (fragment empty by definition) remains a suffix. ?#, ?x#, #frag?notquery and all other lab-ops-hub: container validator returns empty path, empty port and empty userinfo un-normalized — recorded URL differs from the Worker #639 cases are unchanged.
• All three rebuild sites now use it instead of geturl() + markers: _url_with_host, _normalize_validated_url and _url_with_encoded_components. The fetcher's _split_userinfo rebuild, which dropped the markers entirely, uses it too.
• Verdicts unchanged; no accept/refuse change.

Tests

• New Python test test_returns_empty_query_marker_before_a_nonempty_fragment: the issue battery plus percent-decoded / IP / userinfo / encoded-fragment arms, lab-ops-hub: container validator returns empty path, empty port and empty userinfo un-normalized — recorded URL differs from the Worker #639 controls, a _split_userinfo pin and a redirect-handler pin. Ablation exact: with only app.py reverted, only this test fails, with the exact path#frag? divergence.
• TS pin added to the lab-ops-hub: container validator returns empty path, empty port and empty userinfo un-normalized — recorded URL differs from the Worker #639 Worker test for the ?#frag spellings (Worker already returns them).
• Python 59/59 and TS 39/39 locally; ruff format clean.
• Differential vs the real Worker validator under Bun over 480 generated spellings (10 hosts × 4 paths × 12 tails, including ?#frag, ?#, ?x#frag, #frag?notquery): zero differences in verdict or returned form.

Single-repo: no validate_crawl_url/validateCrawlUrl copy in the opencode, openchamber or nix clones (git-grep clean).

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T10:04:42.485969Z	3c999f9	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 30c74e20-d4eb-479b-b811-652d264cf64a

📥 Commits

Reviewing files that changed from the base of the PR and between a1b06f5 and 3c999f9.

📒 Files selected for processing: 3

• pkgs/lab-ops-hub/container/app.py
• pkgs/lab-ops-hub/test/lib.test.ts
• pkgs/lab-ops-hub/test/test_container_validate.py

+----------------------------------------------------------------------------------------------------------------------------------------------------+
| Critically analyze what you read and hear. Don't be swayed by vendors, media hype, or dogma. Analyze information in terms of you and your project. |
+----------------------------------------------------------------------------------------------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}