[dezren39]

Fixes #6677.

Problem

load_allowed_nodes collapsed every read_to_string error into a silent empty list, so a present-but-unreadable .iroh-allowed (UTF-16 save, directory in its place, permission denied) looked exactly like a missing file: allowed peers were denied writes with no diagnostic naming the file.

Change (pkgs/id/crates/id-core/src/access.rs only)

• load_allowed_nodes now matches on the read result: NotFound stays silent and empty (by design); any other error emits warn!("ignoring unreadable allow list {path}: {err}; no nodes from it will be allowed to write") and returns an empty list — fail-closed is preserved, the failure is now visible. This is the helper build_access_policy in id serve calls, so the diagnostic fires on the serve policy-build path through the same tracing channel as the existing per-line invalid-ID warnings in parse_allowed_nodes (unchanged).
• Regression tests with a minimal captured-tracing-subscriber assert the behavior, not just the return value: directory-in-place-of-file and non-UTF-8 (UTF-16LE+BOM bytes) both stay empty AND produce a diagnostic naming .iroh-allowed; a missing file stays empty AND silent; the existing valid-file and parse tests stay green.

Tests

• Laptop, worktree from main 3a437f133f: cargo test --lib load_allowed_nodes in pkgs/id/crates/id-core — 7 passed, 0 failed (incl. the three new tests); the full --lib run in that crate also passed its other suites in the same invocation (121 filtered out were non-matching names in other binaries).

🤖 Filed by repo-queue-worker Lane T in fallback mode (queue backend down 2026-11-06/07); the issue was the task.

---

^{Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0ed62adb-2464-4d92-b728-cd54d666a00f

Commits

Reviewing files that changed from the base of the PR and between 83a6d10 and 92b0c1c.

Files selected for processing: 1

• pkgs/id/crates/id-core/src/access.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[chatgpt-codex-connector]

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-07T02:31:49.748117Z	92b0c1c	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.