[dezren39]

Fixes #672

Problem

bin/muse-proxy.mjs's failure predicate gated both clauses on fullContent.length === 0, so any run that emitted assistant text before failing was returned as a successful finish_reason: 'stop' carrying the truncated text — verified pre-fix with a stub muse for both a run.terminal.failed (exit 0) and a crash (exit 3, no terminal event), in stream and non-stream modes.

Fix

• Failure is judged by the authoritative terminal state when one was emitted (terminalState !== 'completed'), otherwise by the exit code. Partial content no longer masks a failure.
• Completed runs are unchanged, including a non-zero exit code after a completed terminal event (terminal is authoritative), the muse-proxy (PR #479): streaming responses silently drop the terminal text tail that non-streaming returns #484 tail reconciliation, and usage accounting.
• Stream surfacing reuses muse-proxy: streaming execution failure is sent as unframed JSON on a 200 SSE response — clients see an empty successful stream #670: already-sent deltas are followed by the SSE error frame + [DONE], and no 'stop' chunk is emitted. Non-stream gets the 500 error body.
• Error detail: when stderr is empty and the terminal state is the evidence, the message names the terminal state instead of the misleading muse exec exited with code 0.

Tests

• New test partial output then failure: masked success becomes an error in both modes (#672) with stub markers FAILPARTIAL / CRASHPARTIAL covering both failure shapes × both modes.
• node --test bin/muse-proxy.test.mjs: 4/4 pass. Ablation: with only bin/muse-proxy.mjs reverted, exactly the new test fails and the other three pass.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T17:01:02.487430Z	df1dd25	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: a6aa8957-d05a-46c6-8265-f58e9a09b64c

📥 Commits

Reviewing files that changed from the base of the PR and between ba9c76d and df1dd25.

📒 Files selected for processing: 2

• bin/muse-proxy.mjs
• bin/muse-proxy.test.mjs

+--------------------------------------------------------------------------------+
| A bunny is never late, nor is he early, he reviews precisely when he means to. |
+--------------------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}