Skip to content

fix(aggregator): preserve distinct provider display names - #7054

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/11288-6891-provider-display-iterable-underscore-collision
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/11288-6891-provider-display-iterable-underscore-collision

Conversation

@dezren39

@dezren39 dezren39 commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Summary

- spread Iterable twice; always strip leading underscore
+ snapshot input once; keep underscore when its stripped display collides
  • Adds generator and Map.keys iterator coverage plus plain and dotted collision regressions.
  • Canonical IDs and returned map keys remain unchanged.

Closes #6891

Evidence

  • Before: bun test test/provider-display.test.ts — 11 pass, 3 fail (new regressions).
  • After: bun test test/provider-display.test.ts — 14 pass.
  • git diff --check — pass.
  • Full package suite: 1554 pass, 21 fail, 3 errors; environment lacks web-push and other tests timed out. bun run typecheck cannot run because @types/bun is not installed.

Merge Danger

Door: Two-way.

Blast Radius: Low — display strings only; canonical IDs and keys stay intact.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 8, 2026 02:21
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c456c2d5-e3e3-49b5-9bfb-0722c85103e9
Commits

Reviewing files that changed from the base of the PR and between 801ceb9 and c333f08.

Files selected for processing: 2

  • pm-stack/aggregator/src/provider-display.ts
  • pm-stack/aggregator/test/provider-display.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T02:23:26.250307Z c333f08 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aggregator(provider-display): underscore strip breaks one-shot iterables and collapses renamed+plain providers to one display name

1 participant