[dezren39]

Fixes #846

isLightColor (pkgs/id/web/src/cursor-utils.ts) sliced the hex string at fixed 2-char offsets, so CSS 3-digit shorthand colors misaligned: #fff parsed as r=255, g=15, b=NaN, and the NaN luminance comparison silently classified every shorthand color as dark. Malformed input took the same accidental NaN path.

Verified before the fix with the verbatim function in node: isLightColor("#fff") === false and isLightColor("#ff0") === false (both light; expected true).

Change:

• Expand 3-digit shorthand per CSS rules (each digit doubled) before parsing.
• Anything that is not exactly six hex digits returns false explicitly, instead of being decided by a NaN comparison.

Tests: 3 new cases in cursor-utils.test.ts (shorthand expansion incl. #fff/#ff0/#000, shorthand-without-# equivalence, malformed inputs). Focused suite: vitest run src/cursor-utils.test.ts — 76/76 PASS.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 51d937ec-f6ba-43c4-ba93-c664e645ae88

Commits

Reviewing files that changed from the base of the PR and between 16c9f03 and 249c2ac.

Files selected for processing: 2

• pkgs/id/web/src/cursor-utils.test.ts
• pkgs/id/web/src/cursor-utils.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-25T06:18:08.535760Z	249c2ac	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[dezren39]

Sweep verification (2026-10-25): nix flake check leg CANCELLED after 60m19s (started 06:16:53Z, completed 07:17:12Z) — the id-check.yml timeout-minutes:60 cap documented on #551, not a check failure. All other checks SUCCESS (run, treefmt, Nix flake evaluation, CodeRabbit). Verified the change locally on head 249c2ac: vitest run src/cursor-utils.test.ts — 76/76 PASS. Merging per standing directive (verify locally and merge when the flake leg is cap-cancelled).