Skip to content

fix(ci): guard muse/commandcode proxy ports, drop literal ports in opencode.jsonc - #867

Merged
dezren39 merged 1 commit into
mainfrom
sweep/proxy-port-guard-muse-commandcode
Oct 25, 2026
Merged

dezren39 merged 1 commit into
mainfrom
sweep/proxy-port-guard-muse-commandcode

Conversation

@dezren39

@dezren39 dezren39 commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Fixes #866

Problem

nix ci is red on main: check-proxy-port-fallbacks.sh fails because .opencode/opencode.jsonc hardcodes literal proxy ports 18747/18748, and the guard's proxy table was never extended to the two newest proxies (museProxyPort/commandcodeProxyPort in home/common/default.nix). The failure also lands on unrelated PRs branched from current main (seen on PR #857).

Solution

  • Guard table: add MUSE_PROXY_PORT|museProxyPort|bin/muse-proxy.mjs|yes and COMMANDCODE_PROXY_PORT|commandcodeProxyPort|bin/commandcode-proxy.mjs|yes (both scripts already use parseProxyPort with matching fallbacks).
  • opencode.jsonc: commandcode provider baseURL → {env:COMMANDCODE_PROXY_PORT:-18748}; commented-out muse provider baseURL → {env:MUSE_PROXY_PORT:-18747} (keeps the disabled block accurate and out of the literal-port grep).

Verified

bash .github/scripts/check-proxy-port-fallbacks.sh → 'proxy port fallbacks match the home/common/default.nix definitions (7 proxies)', exit 0 (was exit 1 on main).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Bug Fixes
    • Muse and Command Code proxy URLs now use environment-configured port overrides, defaulting to ports 18747 and 18748 when no overrides are set. This keeps the configured proxy URLs aligned with the ports used by their corresponding services.
    • The Muse provider remains commented out; this change does not enable it.

@dezren39
dezren39 requested a review from a team as a code owner October 25, 2026 10:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T10:16:09.133659Z d897f8c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The Muse and CommandCode proxy URLs now use environment-variable port fallbacks. The fallback-check script adds both proxies to its validation list.

Changes: Proxy port fallback checks

Layer / File(s) Summary
Configure and check proxy port fallbacks
.opencode/opencode.jsonc, .github/scripts/check-proxy-port-fallbacks.sh
The Muse and CommandCode proxy URLs use environment-variable fallbacks with default ports 18747 and 18748. The fallback-check script adds both proxies to its records.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related issues

Merge Risk: Minimal · up to d897f

No concrete configuration or validation defect remains in the changed code.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nix ci red on main: proxy-port guard misses muse/commandcode proxies — opencode.jsonc hardcodes 18747/18748

1 participant