You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): guard muse/commandcode proxy ports, drop literal ports in opencode.jsonc - #867
nix ci is red on main: check-proxy-port-fallbacks.sh fails because .opencode/opencode.jsonc hardcodes literal proxy ports 18747/18748, and the guard's proxy table was never extended to the two newest proxies (museProxyPort/commandcodeProxyPort in home/common/default.nix). The failure also lands on unrelated PRs branched from current main (seen on PR #857).
Solution
Guard table: add MUSE_PROXY_PORT|museProxyPort|bin/muse-proxy.mjs|yes and COMMANDCODE_PROXY_PORT|commandcodeProxyPort|bin/commandcode-proxy.mjs|yes (both scripts already use parseProxyPort with matching fallbacks).
opencode.jsonc: commandcode provider baseURL → {env:COMMANDCODE_PROXY_PORT:-18748}; commented-out muse provider baseURL → {env:MUSE_PROXY_PORT:-18747} (keeps the disabled block accurate and out of the literal-port grep).
Verified
bash .github/scripts/check-proxy-port-fallbacks.sh → 'proxy port fallbacks match the home/common/default.nix definitions (7 proxies)', exit 0 (was exit 1 on main).
Need help on this PR? Tag @codesmith-bot with what you need.
Summary by CodeRabbit
Bug Fixes
Muse and Command Code proxy URLs now use environment-configured port overrides, defaulting to ports 18747 and 18748 when no overrides are set. This keeps the configured proxy URLs aligned with the ports used by their corresponding services.
The Muse provider remains commented out; this change does not enable it.
The Muse and CommandCode proxy URLs now use environment-variable port fallbacks. The fallback-check script adds both proxies to its validation list.
Changes: Proxy port fallback checks
Layer / File(s)
Summary
Configure and check proxy port fallbacks .opencode/opencode.jsonc, .github/scripts/check-proxy-port-fallbacks.sh
The Muse and CommandCode proxy URLs use environment-variable fallbacks with default ports 18747 and 18748. The fallback-check script adds both proxies to its records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #866
Problem
nix ciis red on main:check-proxy-port-fallbacks.shfails because.opencode/opencode.jsonchardcodes literal proxy ports 18747/18748, and the guard's proxy table was never extended to the two newest proxies (museProxyPort/commandcodeProxyPortin home/common/default.nix). The failure also lands on unrelated PRs branched from current main (seen on PR #857).Solution
MUSE_PROXY_PORT|museProxyPort|bin/muse-proxy.mjs|yesandCOMMANDCODE_PROXY_PORT|commandcodeProxyPort|bin/commandcode-proxy.mjs|yes(both scripts already useparseProxyPortwith matching fallbacks).{env:COMMANDCODE_PROXY_PORT:-18748}; commented-out muse provider baseURL →{env:MUSE_PROXY_PORT:-18747}(keeps the disabled block accurate and out of the literal-port grep).Verified
bash .github/scripts/check-proxy-port-fallbacks.sh→ 'proxy port fallbacks match the home/common/default.nix definitions (7 proxies)', exit 0 (was exit 1 on main).Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit