Skip to content

fix(id): carry /logs seconds in SSH command mode (#819) - #909

Merged
dezren39 merged 1 commit into
mainfrom
sweep/819-ssh-logs-seconds
Oct 25, 2026
Merged

dezren39 merged 1 commit into
mainfrom
sweep/819-ssh-logs-seconds

Conversation

@dezren39

@dezren39 dezren39 commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Fixes #819

Problem

#819's remaining half: in SSH command mode, WorldCommand::Logs was a unit variant, so world_command() dropped the seconds that parse_line had parsed from /logs <seconds> (WorldLine::Logs { seconds }). The user asked for a bounded window and the shell silently discarded it — the reply never mentioned the argument at all. (The pump half of #819 and the SSH Message half were already fixed on main by the Phase 13 shell-contract work; PR #868 was closed as superseded for that reason.)

Solution

  • WorldCommand::Logs now carries seconds: Option<u64> (pkgs/id/src/world_ssh.rs), matching WorldLine::Logs.
  • world_command() threads the parsed seconds through instead of matching { .. }.
  • The command-mode reply now names the ignored window: 'event tailing is not available in command mode (the requested Ns window is ignored here); …' — honest about the limitation instead of silent.
  • Existing parse tests updated to pin the carried value (/logs → None, /logs 5 → Some(5)).

Verification

  • Local: cargo test --no-default-features --features ssh --lib world_ssh compiled and ran the 49 world_ssh tests (sandbox FS was too slow to re-run the summary cleanly; CI is the verifier of record for the full suite).
  • rustfmt (edition 2024, toolchain 1.99.0) clean on the touched file.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

…g it (#819)

WorldCommand::Logs in the SSH shell was a unit variant, so the seconds
parsed from '/logs <seconds>' were silently dropped when world_command()
converted WorldLine::Logs. The variant now carries seconds: Option<u64>,
world_command threads it through, and the command-mode reply names the
requested window it is ignoring instead of pretending it was never given.
@dezren39
dezren39 requested a review from a team as a code owner October 25, 2026 19:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T19:02:50.704048Z 50e2d91 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 66100a9d-1175-402c-8c63-e39e603c6d67
Commits

Reviewing files that changed from the base of the PR and between 86e6f30 and 50e2d91.

Files selected for processing: 1
  • pkgs/id/src/world_ssh.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant