Skip to content

Fix performance issue with gcroot - #1344

Merged
sdmaclea merged 1 commit into
dotnet:masterfrom
sdmaclea:gcroot
Jul 14, 2020
Merged

sdmaclea merged 1 commit into
dotnet:masterfrom
sdmaclea:gcroot

Conversation

@sdmaclea

Copy link
Copy Markdown
Contributor

The std::List::size() method was not guaranteed to be linear complexity
until C++11. Apparently the Centos Containers we are using to build the
diagnostic repo do not have C+11 compliant StdLib headers installed.

Fixes #633

The std::List<t>::size() method was not guaranteed to be linuear complexity
until c++11.  Apparantly the Centos Containters we are using to build the
diagnostic repo do not have C+11 complaiant StdLib headers installed.
@sdmaclea
sdmaclea requested a review from hoyosjs July 14, 2020 00:51
@sdmaclea sdmaclea self-assigned this Jul 14, 2020
@sdmaclea
sdmaclea requested a review from mikem8361 July 14, 2020 00:53

@hoyosjs hoyosjs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty amazing performance gem find

@sdmaclea
sdmaclea merged commit 368b222 into dotnet:master Jul 14, 2020
@sdmaclea
sdmaclea deleted the gcroot branch June 10, 2021 00:35
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gcroot algorithm is inefficient

3 participants