Skip to content

Fix performance issue with gcroot - #1345

Closed
sdmaclea wants to merge 1 commit into
dotnet:release/stablefrom
sdmaclea:release/stable
Closed

sdmaclea wants to merge 1 commit into
dotnet:release/stablefrom
sdmaclea:release/stable

Conversation

@sdmaclea

Copy link
Copy Markdown
Contributor

The std::List::size() method was not guaranteed to be linear complexity
until C++11. Apparently the Centos Containers we are using to build the
diagnostic repo do not have C+11 compliant StdLib headers installed.

The std::List<t>::size() method was not guaranteed to be linuear complexity
until c++11.  Apparantly the Centos Containters we are using to build the
diagnostic repo do not have C+11 complaiant StdLib headers installed.
@sdmaclea
sdmaclea requested review from hoyosjs and mikem8361 July 14, 2020 00:53
@sdmaclea sdmaclea self-assigned this Jul 14, 2020
@mikem8361

Copy link
Copy Markdown
Contributor

You have two PRs up for the same change. I approved #1344.

@sdmaclea

sdmaclea commented Jul 14, 2020 •

Copy link
Copy Markdown
Contributor Author

This is to stable. since it improves gcroot 100x. We might want it released early... Up to you

@mikem8361

Copy link
Copy Markdown
Contributor

I don't think we need this PR anymore.

@sdmaclea sdmaclea closed this Aug 18, 2020
@sdmaclea
sdmaclea deleted the release/stable branch August 18, 2020 19:42
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants