You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
regression net9.0 ServicePoint throws PNSE on browser #113174
#94510 forwarded all of ServicePoint to System.Net.Requests but browser marks all of System.Net.Requests as unsupported so the change unintentionally changed the browser API without any of the tooling catching the difference.
APICompat catches binary breaking changes to type shape. IIUC this wasn't binary breaking but the implementation changed from "real" to not supported?
Or is this more a supported-platform thing, where we moved a type into an assembly which had different supported platform attributes? If that's the case then it would be a feature request for APICompat to have first-class knowledge of SupportPlatform attributes. Today we only look for simple differences in attributes, we don't try to encode the behavior of them since each is bespoke.
Activity
dotnet-policy-service commentedon Mar 5, 2025
Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.
lewing commentedon Mar 5, 2025
@ericstj mildly interesting apicompat limitation here
[-]ServicePoint throws on browser[/-][+]regression net9.0 ServicePoint throws PNSE on browser[/+]lewing commentedon Mar 6, 2025
I doubt we need to fix the api surface but we should document the breaking change and ideally improve the tooling
ericstj commentedon Mar 6, 2025
APICompat catches binary breaking changes to type shape. IIUC this wasn't binary breaking but the implementation changed from "real" to not supported?
Or is this more a supported-platform thing, where we moved a type into an assembly which had different supported platform attributes? If that's the case then it would be a feature request for APICompat to have first-class knowledge of SupportPlatform attributes. Today we only look for simple differences in attributes, we don't try to encode the behavior of them since each is bespoke.
.NET9: Fixes WebAssembly or browser scenarios by conditionally settin…
wfurt commentedon Mar 18, 2025
It is not clear to me what we want to do here.... I assume this will not change so perhaps documentation?