Skip to content

regression net9.0 ServicePoint throws PNSE on browser #113174

Open

Description

@lewing

#94510 forwarded all of ServicePoint to System.Net.Requests but browser marks all of System.Net.Requests as unsupported so the change unintentionally changed the browser API without any of the tooling catching the difference.

see Azure/azure-cosmos-dotnet-v3#5029 for context

Activity

  1. dotnet-policy-service commented on Mar 5, 2025

    @dotnet-policy-service
    Contributor

    Tagging subscribers to this area: @dotnet/ncl
    See info in area-owners.md if you want to be subscribed.

  2. lewing commented on Mar 5, 2025

    @lewing
    MemberAuthor

    @ericstj mildly interesting apicompat limitation here

  3. changed the title [-]ServicePoint throws on browser[/-] [+]regression net9.0 ServicePoint throws PNSE on browser[/+] on Mar 5, 2025
  4. added this to the 9.0.x milestone on Mar 6, 2025
  5. lewing commented on Mar 6, 2025

    @lewing
    MemberAuthor

    I doubt we need to fix the api surface but we should document the breaking change and ideally improve the tooling

  6. ericstj commented on Mar 6, 2025

    @ericstj
    Member

    APICompat catches binary breaking changes to type shape. IIUC this wasn't binary breaking but the implementation changed from "real" to not supported?

    Or is this more a supported-platform thing, where we moved a type into an assembly which had different supported platform attributes? If that's the case then it would be a feature request for APICompat to have first-class knowledge of SupportPlatform attributes. Today we only look for simple differences in attributes, we don't try to encode the behavior of them since each is bespoke.

  7. wfurt commented on Mar 18, 2025

    @wfurt
    Member

    It is not clear to me what we want to do here.... I assume this will not change so perhaps documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions