Repository navigation
fix(https_fn): pass message to HttpsError super().__init__ (fixes #314) - #315
Open
Aayush99910 wants to merge 2 commits into
Open
Aayush99910 wants to merge 2 commits into
Aayush99910 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates HttpsError to pass the error message to its superclass initializer, ensuring that str(err) and err.args correctly contain the message, and adds a corresponding unit test. The review feedback recommends addressing minor PEP 8 and PEP 257 style issues in the new test, such as trailing whitespace, docstring formatting, and a missing newline at the end of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HttpsError.__init__storesself.messagebut callssuper().__init__()with no arguments. As a result,str(err)returns''anderr.argsis(), so logging the exception prints no message.This PR passes
messagetosuper().__init__(message)so it's preserved on the baseException.Testing
Added
test_https_error_passes_message_to_superwhich assertsstr(err)anderr.argscontain the message. All 137 tests pass.Fixes #314