Skip to content

fix(https_fn): pass message to HttpsError super().__init__ (fixes #314) #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aayush99910 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(https_fn): pass message to HttpsError super().__init__ (fixes #314) #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312254c
fix(https_fn): pass message to HttpsError super().__init__ (fixes #314)
Aayush99910 Oct 7, 2026
5a101ac
chore(test): fix formatting flagged by ruff
Aayush99910 Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/firebase_functions/https_fn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def __init__(

self._http_error_code = _error_code_map[code]

super().__init__()
super().__init__(message)

def _as_dict(self) -> _HttpErrorWireFormat:
if self.details is None:
Expand Down
13 changes: 13 additions & 0 deletions tests/test_https_fn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,16 @@ def init():
decorated_func(request)

self.assertEqual("world", hello)

def test_https_error_passes_message_to_super(self):
"""
HttpsError should pass the message to the base Exception so that
str(err) and err.args contain the message.
"""
err = https_fn.HttpsError(
code=https_fn.FunctionsErrorCode.INVALID_ARGUMENT,
message="something went wrong",
)

self.assertEqual(str(err), "something went wrong")
self.assertEqual(err.args, ("something went wrong",))
Loading