test(browser): Fix flaky reportPageLoaded duration assertion - #24814
Merged
Merged
Conversation
The pageload span starts at navigation start, but the 2.5s timeout before reportPageLoaded() only starts once the bundle has executed, so slow CI runners can push the duration past 3s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
September 29, 2026 09:07
mydea
requested review from
Lms24 and
logaretm
and removed request for
a team
September 29, 2026 09:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reportPageLoadeddefault tests flaked in CI with a pageload span duration of ~3.16s against a< 3upper bound.Root cause: the pageload span starts at navigation start, but the 2.5s
setTimeoutbeforeSentry.reportPageLoaded()only begins once the test bundle has executed, so page load time on a slow runner is added on top. Bumping the upper bound to 4s gives enough headroom; theidle_span_finish_reason: 'reportPageLoaded'assertion already guarantees the span wasn't ended by a timeout. Applied to both the static and streamed variants.🤖 Generated with Claude Code