Skip to content

test(browser): Fix flaky reportPageLoaded duration assertion #24814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 1 commit into from
Sep 29, 2026
Merged

test(browser): Fix flaky reportPageLoaded duration assertion #24814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...-tests/suites/tracing/browserTracingIntegration/reportPageLoaded-streamed/default/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ sentryTest(
[SEMANTIC_ATTRIBUTE_SENTRY_IDLE_SPAN_FINISH_REASON]: { type: 'string', value: 'reportPageLoaded' },
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
// We wait for 2.5 seconds before calling Sentry.reportPageLoaded(). The span starts at navigation start,
// but the timeout only starts once the bundle has executed, so allow generous upper headroom for slow CI.
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
expect(spanDurationSeconds).toBeLessThan(4);
},
);
6 changes: 3 additions & 3 deletions ...tegration-tests/suites/tracing/browserTracingIntegration/reportPageLoaded/default/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ sentryTest(
['sentry.idle_span_finish_reason']: 'reportPageLoaded',
});

// We wait for 2.5 seconds before calling Sentry.reportPageLoaded()
// the margins are to account for timing weirdness in CI to avoid flakes
// We wait for 2.5 seconds before calling Sentry.reportPageLoaded(). The span starts at navigation start,
// but the timeout only starts once the bundle has executed, so allow generous upper headroom for slow CI.
expect(spanDurationSeconds).toBeGreaterThan(2);
expect(spanDurationSeconds).toBeLessThan(3);
expect(spanDurationSeconds).toBeLessThan(4);
},
);
Loading