You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Revisit the need of DOCLET_VERSION env variable (in Jan 2023) #8754
There is an issue in java-docfx-doclet for publishing the doclet artifact to maven central: googleapis/java-docfx-doclet#105. I think this should be the long term solution so that we don't need to manually update the version in shared-configs.
DOCLET_VERSION is not needed by default (since shared-configs is specifying the version). I kept the env_var in g3 so that we can publish/update docs by manually setting the DOCLET_VERSION env_var in the fusion job. This is so that we can publish/ update docs even if there is an issue in any future version of the doclet. We can manually rollback the doclet version and publish docs without having to wait for shared-configs' doclet version rollback to be released.
I think this property can be removed from java-shared-config in general as the publish_javadoc11.sh job is now within google3 and doesn't use this property AFAIK. @burkedavison wdyt?
Activity
lqiu96 commentedon Nov 9, 2022
There is an issue in
java-docfx-docletfor publishing the doclet artifact to maven central: googleapis/java-docfx-doclet#105. I think this should be the long term solution so that we don't need to manually update the version inshared-configs.DOCLET_VERSIONis not needed by default (sinceshared-configsis specifying the version). I kept the env_var in g3 so that we can publish/update docs by manually setting theDOCLET_VERSIONenv_var in the fusion job. This is so that we can publish/ update docs even if there is an issue in any future version of the doclet. We can manually rollback the doclet version and publish docs without having to wait for shared-configs' doclet version rollback to be released.alicejli commentedon Dec 12, 2023
I think this property can be removed from
java-shared-configin general as thepublish_javadoc11.shjob is now within google3 and doesn't use this property AFAIK. @burkedavison wdyt?burkedavison commentedon Dec 12, 2023
Agreed. Not used. Can be removed.
alicejli commentedon Mar 27, 2024
Closing this issue as the doclet is managed in
java-shared-configand the release scripts are in g3 now.