Repository navigation
chore: Use shared-config doclet version as default - #8753
Merged
Merged
Conversation
suztomo
approved these changes
Nov 9, 2022
suztomo
left a comment
Member
There was a problem hiding this comment.
Approving. But remember that the environment variables and newly added if-statements make troubleshooting a slightly difficult and might introduce new problem later.
When it was unclear what to do, these ad-hoc variables made sense. When we know the infrastructure setup is stable, it may make sense to remove the variables and if-statements altogether, in favor of a proper, standard process to update the doclet version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing this kokoro env_var version since we can have
shared-configsdetermine the doclet version (https://github.com/googleapis/java-shared-config/blob/29e20eb8809fc3dc985111bbaecd09c281222484/pom.xml#L698)I'll keep the config in g3 so that we can override this env_var with any custom doclet version in any future fusion job.