Skip to content

chore: Use shared-config doclet version as default - #8753

Merged
lqiu96 merged 1 commit into
mainfrom
main-docfx_version
Nov 9, 2022
Merged

lqiu96 merged 1 commit into
mainfrom
main-docfx_version

Conversation

@lqiu96

@lqiu96 lqiu96 commented Nov 9, 2022

Copy link
Copy Markdown
Member

Removing this kokoro env_var version since we can have shared-configs determine the doclet version (https://github.com/googleapis/java-shared-config/blob/29e20eb8809fc3dc985111bbaecd09c281222484/pom.xml#L698)

env_vars: {
  key: "DOCLET_VERSION"
  value: "1.7.0"
}

I'll keep the config in g3 so that we can override this env_var with any custom doclet version in any future fusion job.

@lqiu96
lqiu96 requested a review from suztomo November 9, 2022 16:39

@suztomo suztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. But remember that the environment variables and newly added if-statements make troubleshooting a slightly difficult and might introduce new problem later.

When it was unclear what to do, these ad-hoc variables made sense. When we know the infrastructure setup is stable, it may make sense to remove the variables and if-statements altogether, in favor of a proper, standard process to update the doclet version.

@lqiu96
lqiu96 merged commit f8bf75a into main Nov 9, 2022
@lqiu96
lqiu96 deleted the main-docfx_version branch November 9, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants