Repository navigation
Pass in information for the module name resolution when resolutions from file are partially used - #49738
Merged
Conversation
Sheetal Nandi (sheetalkamat)
force-pushed
the
partialModuleResolutionReuse
branch
from
September 23, 2022 17:28
2a075d6 to
5e8682a
Compare
Member
Author
|
Ping for review.. This is marked as 4.9 issue. Note that this tries to fix the issue without breaking API users. |
Sheetal Nandi (sheetalkamat)
requested review from
Andrew Branch (andrewbranch) and
Wesley Wigham (weswigham)
October 31, 2022 20:49
Wesley Wigham (weswigham)
approved these changes
Nov 7, 2022
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
We should probably make a note to deprecate this signature and replace it with a cleaner one at some point... It's had to change in a backwards-compatible way a lot recently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48229