Repository navigation
Reuse type reference directive resolutions - #49750
Merged
Merged
Conversation
Member
|
Sheetal Nandi (@sheetalkamat) think this needs a sync now that the other PR is merged~ |
Member
Author
|
Wesley Wigham (@weswigham) yes working on it. |
Sheetal Nandi (sheetalkamat)
force-pushed
the
typeRefDirectiveReuse
branch
from
November 7, 2022 20:58
21b2d0b to
a9e619c
Compare
Member
Author
|
Wesley Wigham (@weswigham) done. Ready to review again |
Wesley Wigham (weswigham)
approved these changes
Nov 7, 2022
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
We at least document the parameters to this function in our API, since which types for which parameters are "modern" and "preferred" probably isn't immediately obvious anymore at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #49738 to reuse type reference directive resolutions