Repository navigation
Windows ML: Fix crash with null provider options for VitisAI EP - #629
Merged
Merged
Conversation
shisan (qiutongMS)
pushed a commit
that referenced
this pull request
Aug 25, 2026
Align the WindowsML central package set with stable Windows App SDK 2.1.3 and port the main-only EP performance chain from PRs #588, #634, #635, #629, #642, and #643. Preserve release Central Package Management, defer the PR #643 legacy sample removals to final integration review, and record the x64 Release validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CppConsoleDesktop.SelfContained.exe was crashing with an access violation when using VitisAIExecutionProvider. My command line was
CppConsoleDesktop.SelfContained.exe --ep_name VitisAIExecutionProvider --device_type NPU --compileThe crash is because ONNX dereferences a null OrtKeyValuePairs* when reading the EP options.
In the Performance Configurator header, GetVitisAIOptions was returning Ort::KeyValuePairs(nullptr), which wraps a null internal pointer. This fix changed it to return a default-constructed Ort::KeyValuePairs which should be a valid object for ORT to query.
Tested by rebuilding and running the sample. The app no longer crashes and successfully completes inference on the SqueezeNet model using the EP.
Target Release
2.0
Checklist
Note that /azp run currently isn't working for this repo.