Repository navigation
Insufficient integration tests #219
Description
Specify your setup
- version of @node-oauth/oauth2-server: 5.0.0-rc.1
Describe the bug
The integration tests do not properly cover the regressions, introduced by the switch to native async/await. This is due to the original integration tests do not really test, whether the correct values are passed to the model as most model functions are not covering parameters or return nearly nothing.
This already resulted in:
Proposal:
All integration tests should also cover proper model testing.
We should target this for 5.0.0, because there may be more parts affected as may have been revealed yet.
Activity
jankapunkt commentedon Aug 26, 2023
This is partially implemented via #224 but we will add another PR with the rest
jankapunkt commentedon Oct 1, 2023
Whoever wants to go to implement this, we basically need in the folder
/test/complianceanother test implementation forauthorization_code_grant_type(acgt) workflow.Fortunately we got the other types already covered so you can take a look at the implementations in these folders and use the techniques you find in there.
Beware, that the acgt is the most complex type of all workflows and requires very thorough implementation for different scenarios (early rejections, full success, refresh etc.).
We will carefully review this one and may even add a commit here and there to support this.
jankapunkt commentedon Nov 7, 2023
Another compliance test would be, on top of
authorization_code_grant_type, to have a fully compliant pkce test setup.