Conversation
…eing accepted accept() can return a socket without filling in the peer address when the client has already reset the connection. The address buffer was left uninitialized and php_network_populate_name_from_sockaddr() does not set the output string for an unknown family, so zend_string_dup() was handed a NULL. Zero the buffer and fall back to "-" when the address is unknown.
devnexen
force-pushed
the
fix-cli-server-reset-crash
branch
from
September 22, 2026 10:08
5df65a1 to
103a931
Compare
devnexen
marked this pull request as ready for review
September 22, 2026 10:51
Contributor
|
Looks good to me. It seems to me that the test does not reliably test this, is that right? Even so, I don't think there's a better way to test this. Does this need a NEWS entry? |
Member
Author
|
there is a "follow-up" PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accept() can return a socket without filling in the peer address when the client has already reset the connection. The address buffer was left uninitialized and php_network_populate_name_from_sockaddr() does not set the output string for an unknown family, so zend_string_dup() was handed a NULL.
Zero the buffer and fall back to "-" when the address is unknown.