Conversation
…tion The test resets the connection as soon as it is opened, so the reset could reach the server while the connection was still in the listen backlog. The server then never saw the request and the expected error was never logged. Complete a request on a second connection first: the accept queue is FIFO, so a response on the later connection means the earlier one has been accepted, and the reset is guaranteed to hit an established connection.
Member
Author
|
To fix/harden this failing test. |
Contributor
|
I also saw that this test was flaky, but I couldn't reproduce it locally so I couldn't get anywhere with debugging or fixing it. Your diagnosis and fix look reasonable. |
devnexen
marked this pull request as ready for review
September 24, 2026 09:41
LamentXU123
approved these changes
Sep 26, 2026
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Let's see after this is merged can this be fixed in future CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion
The test resets the connection as soon as it is opened, so the reset could reach the server while the connection was still in the listen backlog. The server then never saw the request and the expected error was never logged.
Complete a request on a second connection first: the accept queue is FIFO, so a response on the later connection means the earlier one has been accepted, and the reset is guaranteed to hit an established connection.