Repository navigation
Zend: Lazy objects minor refactorings - #23998
Merged
Merged
Conversation
This is a common implementation for various lazy object methods
ndossche
reviewed
Oct 1, 2026
| /* }}} */ | ||
|
|
||
| void reflection_class_new_lazy(INTERNAL_FUNCTION_PARAMETERS, | ||
| static zend_always_inline void reflection_class_new_lazy(INTERNAL_FUNCTION_PARAMETERS, |
Member
There was a problem hiding this comment.
I'm not sure this is a good idea, and you have to be careful doing such changes without measuring.
Marking things inline makes code locality and code size worse. This is a simple pass-through function shared by four callers... Does it really need specialization wrt is_reset? Doubtful. Does it need specialization wrt strategy? Certainly not.
Member
Author
There was a problem hiding this comment.
I'll revert that bit then, I saw that it was not used elsewhere, and so thought inlining for the different calls made sense. But I guess leaving that choice to the compiler is also sensible.
Girgias
added a commit
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.