Repository navigation
Zend: derive lazy object initializer callble from FCC - #24000
Merged
Merged
Conversation
Side benefit: this reduces the struct from 64 bytes to 48.
Girgias
force-pushed
the
2026-09-lazy-initializer
branch
from
October 1, 2026 12:06
7a195a6 to
5002906
Compare
Girgias
marked this pull request as ready for review
October 5, 2026 11:58
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
I'm not an expert on the reflection code for lazy objects, but I'm a bit worried that the xfail test is now failing, so not marking this as approved
but, as for as ext/reflection is concerned, if those who know about lazy objects are okay with this, no strong objections from me
Member
Author
|
I'm waiting for Arnaud to have a look on the Lazy Object side, I think the reason is that a destructor is now fired earlier because we no longer store an extra zval reference to it. But that's just a theory. |
Trigger GC explicitly during lazy object realization instead of relying on buffer size trigger.
arnaud-lb
approved these changes
Oct 9, 2026
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
I've fixed the test: It was relying on the GC to be triggered exactly in zend_lazy_object_info_dtor_func(), but this wasn't happening anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #23998.
We do not need the initializer zval as we can derive it from the initializer FCC. This means we can save some space for the struct.
The only thing this seems to change is the GC behaviour which I don't fully understand, so I currently marked that test as XFAIL.