[t3dotgg]

The UI overhaul put a 1px ring around brand editor icons in the thread details panel. The goal was to keep pale icons visible on the card. Instead, it drew a box around the VS Code logo, and it looked bad.

Before:

After:

The fix removes the ring. Brand icons now render plain, the same as the other panel icons.

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 95b6e46

Macroscope's review found this PR approvable — This PR only removes the conditional border and ring styling around brand editor icons in the thread-details panel. Editor behavior, accessibility, and all non-visual logic remain unchanged.

Notes:

• All code in this push has already been reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: t3/fix-vscode-icon-border
• File: .coderabbit.config.ts
• Commit: 95b6e46
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 290b99d6-daa6-46b4-aa76-fdc46560f520

Commits

Reviewing files that changed from the base of the PR and between 72d4dc9 and 95b6e46.

Files selected for processing: 1

• apps/web/src/components/chat/OpenInPicker.tsx

Files with no reviewable changes: 1

• apps/web/src/components/chat/OpenInPicker.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The panel’s primary editor control no longer applies a conditional hairline ring to brand icons. No public declarations changed.

Changes: Panel icon styling

Layer / File(s)	Summary
Remove panel icon ring apps/web/src/components/chat/OpenInPicker.tsx	Removed the panel-only black or dark-mode white hairline ring from brand icons.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Possibly related PRs

• pingdotgg/t3code#24865: Adds the same panel brand-icon ring that this change removes.
• pingdotgg/t3code#25251: Changes panel editor icon styling and retains the brand-icon ring.
• pingdotgg/t3code#24837: Adds the panel editor icon’s grayscale treatment and brand-icon ring.

Merge Risk: Minimal · up to 95b6e

The VS Code icon should appear without the unwanted box; no issue requiring a fix before merge is established.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description states the problem (a 1px ring around brand editor icons in the thread details panel boxes the VS Code logo), includes before/after screenshots, and explains the fix (the ring is remov…	Add a Scope and approval section. Link the triaged bug issue or discussion with maintainer approval, or explain why this very small, focused fix of an obvious bug qualifies without a prior issue or discussion. Add a Verification section tha…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly identifies the web fix and the unwanted box around the VS Code icon.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description states the problem (a 1px ring around brand editor icons in the thread details panel boxes the VS Code logo), includes before/after screenshots, and explains the fix (the ring is removed so brand icons render plain). It is a small, focused UI fix. However, the template asks for a Scope and approval section (linked triaged issue or maintainer-approved discussion, or an explanation of why a small obvious bug fix qualifies without one) and a Verification section (focused tests or manual checks run and their observed results). Neither is present. The Change section is brief but adequate. The description also lacks the conventional commit title format guidance, though the title in the objectives follows that style. The description is mostly complete on problem, change, and visual evidence, but it is missing two required sections.

Resolution

Add a Scope and approval section. Link the triaged bug issue or discussion with maintainer approval, or explain why this very small, focused fix of an obvious bug qualifies without a prior issue or discussion. Add a Verification section that lists the focused checks run (for example, rendering the thread details panel and confirming the VS Code icon has no border in light and dark themes) and the observed results. Note anything not checked. Under the Problem section, state the expected behavior and reproduction steps. Under the Change section, state the component touched (apps/web/src/components/chat/OpenInPicker.tsx) and why removing the ring is the right fix. Also consider replacing the agent attribution line with the model and harness used, as the template requests.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}