Repository navigation
BUGFIX: New design composer footer no longer floats off the bottom - #25326
bmdavis419 wants to merge 4 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained composer layout fix: redesign-only padding is corrected and the transition now uses the footer’s measured height rather than a fixed value. It does not alter settings defaults, schemas, security-sensitive code, or production infrastructure. You can add or adjust custom eligibility rules. Learn more. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f82f154 to
56b9df3
Compare
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Footer spacing and resting geometry apps/web/src/components/chat/ChatComposer.tsx, apps/web/src/components/chat/useComposerRestingTransition.ts |
The footer adds redesign-specific bottom padding when isComposerResting is false. The transition derives the footer’s bottom offset and animated height from its measured rectangle, and applies positioning only when the footer and rectangle are available. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related PRs
- pingdotgg/t3code#24865: Introduces redesign composer footer controls and resting layout.
- pingdotgg/t3code#18594: Changes initial-layout and resize geometry in
useComposerRestingTransition. - pingdotgg/t3code#24825: Refactors
ChatComposerand changes geometry callbacks and ref handling inuseComposerRestingTransition.
Suggested reviewers: juliusmarminge
Merge Risk: 
Minimal · up to 14e05
-
No actionable merge-blocking risk is established for this layout change.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description explains the problem, fix, affected behavior, manual verification, and includes before/after screenshots. It does not use the template headings or explicitly document maintainer approval, but it is sufficiently complete for this focused bug fix.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Dismissing prior approval to re-evaluate 14e0514
|
Note Written by thanks @bmdavis419. your redesign-only 8px spacing fixes the detached footer without changing classic mode. i kept your commit, merged current main, and limited the padding override to the expanded composer so the collapsed row retains zero padding. the expansion animation now pins the measured footer height instead of forcing 48px, avoiding a jump with the shorter footer. the final diff against main is two files, five additions and three deletions. no unrelated pieces of the original were dropped. verification passed:
unverified: electron shell and remote/relay connections. this change is confined to the shared web composer's presentation; native mobile has separate components. before, current main: after, same data and theme: scroll collapse and focus expansion: |



The new design's composer footer now has 8px of bottom padding instead of 16px, so the controls row no longer floats above the composer's bottom edge.
redesign:pb-2 redesign:sm:pb-2on the footer row. The classic look keepspb-3 sm:pb-4.Before / after (latest main, Ocean, dark):
Important files
apps/web/src/components/chat/ChatComposer.tsxdata-chat-composer-footerrow.🤖 Generated with Claude Code