Skip to content

BUGFIX: New design composer footer no longer floats off the bottom - #25326

Open
bmdavis419 wants to merge 4 commits into
mainfrom
t3/composer-footer-padding
Open

bmdavis419 wants to merge 4 commits into
mainfrom
t3/composer-footer-padding

Conversation

@bmdavis419

@bmdavis419 bmdavis419 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Generated by one of Ben Davis' agents

Harness Claude Code
Orchestrator T3 Code
Model Claude Opus 5.5 · unknown reasoning

The new design's composer footer now has 8px of bottom padding instead of 16px, so the controls row no longer floats above the composer's bottom edge.

  • Problem: with 16px under a row of 28px pickers and a 32px send button, the controls look detached from the composer. This came up while reviewing the new design. 12px was tried first and still felt loose.
  • Fix: redesign:pb-2 redesign:sm:pb-2 on the footer row. The classic look keeps pb-3 sm:pb-4.
  • Checked in the real app on the latest main, in dark mode with the Ocean theme, on both the new-thread view (with the context strip under the composer) and an existing thread.

Before / after (latest main, Ocean, dark):

footer-before.png
footer-after.png

Important files

  • apps/web/src/components/chat/ChatComposer.tsx
    • Adds the redesign-scoped bottom padding to the data-chat-composer-footer row.

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 26, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 14e0514

Macroscope's review found this PR approvable — This is a small, self-contained composer layout fix: redesign-only padding is corrected and the transition now uses the footer’s measured height rather than a fixed value. It does not alter settings defaults, schemas, security-sensitive code, or production infrastructure.

You can add or adjust custom eligibility rules. Learn more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bmdavis419
bmdavis419 force-pushed the t3/composer-footer-padding branch from f82f154 to 56b9df3 Compare October 26, 2026 05:05
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between fe86738 and 14e0514.

Files selected for processing: 1
  • apps/web/src/components/chat/useComposerRestingTransition.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The chat composer now applies redesign-specific bottom padding when it is not resting. The resting transition uses the measured footer rectangle to calculate its bottom offset and animated height.

Changes: Composer Footer Layout

Layer / File(s) Summary
Footer spacing and resting geometry
apps/web/src/components/chat/ChatComposer.tsx, apps/web/src/components/chat/useComposerRestingTransition.ts
The footer adds redesign-specific bottom padding when isComposerResting is false. The transition derives the footer’s bottom offset and animated height from its measured rectangle, and applies positioning only when the footer and rectangle are available.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 14e05

No actionable merge-blocking risk is established for this layout change.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the primary change: fixing the redesigned composer footer position.
Description check Passed The description explains the problem, fix, affected behavior, manual verification, and includes before/after screenshots. It does not use the template headings or explicitly document maintainer approv…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, fix, affected behavior, manual verification, and includes before/after screenshots. It does not use the template headings or explicitly document maintainer approval, but it is sufficiently complete for this focused bug fix.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 27, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 27, 2026 00:45

Dismissing prior approval to re-evaluate 14e0514

maria-rcks commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

thanks @bmdavis419. your redesign-only 8px spacing fixes the detached footer without changing classic mode. i kept your commit, merged current main, and limited the padding override to the expanded composer so the collapsed row retains zero padding. the expansion animation now pins the measured footer height instead of forcing 48px, avoiding a jump with the shorter footer.

the final diff against main is two files, five additions and three deletions. no unrelated pieces of the original were dropped.

verification passed:

  • blacksmith vp run check:changed: formatting, lint, knip, and affected typechecks.
  • blacksmith vp test run apps/web/src/components/composerFooterLayout.test.ts: four tests.
  • system chrome: desktop main 16px → new design 8px; narrow new design 8px; classic desktop 16px and narrow 12px; new-thread and existing-thread views; runtime-mode menu; real provider turn through the send button.
  • scrolling collapse and focus expansion with 300ms animations: collapsed bottom padding 0px; expanded footer stays 40px through animation cleanup. both independent final reviewers found no remaining issues on 14e05149c6e352e895793c3bc6e7743864f74fc2.

unverified: electron shell and remote/relay connections. this change is confined to the shared web composer's presentation; native mobile has separate components.

before, current main:

main composer footer with 16px bottom padding

after, same data and theme:

updated composer footer with 8px bottom padding

scroll collapse and focus expansion:

composer collapse and expansion with measured footer height

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants