Repository navigation
fix(web): prevent permissions label from shrinking on click - #26470
UtkarshUsername wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds menu-popup semantics to the permissions button, which also excludes it from the existing press-shrink animation. Permission behavior and product defaults remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Declare menu behavior apps/web/src/components/ComposerContextPermissions.tsx |
The permissions control now declares that it opens a menu using aria-haspopup="menu". |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- pingdotgg/t3code#25869: Adds the
ComposerControlselector that excludes controls witharia-haspopup; this change adds that attribute to the permissions control.
Suggested reviewers: t3dotgg
Merge Risk: 
Minimal · up to 5d77b
-
The change adds menu semantics to the permissions control without an identified behavior or permission regression.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the visual bug, identifies the fix and scope, provides before and after evidence, and lists validation results. It does not explicitly state that browser verification was not run, but the description is otherwise complete.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Problem
On the new thread page, pressing the permissions label below the composer briefly shrinks it, making the text appear to jump as the permissions menu opens.
Change
Mark the permissions button with
aria-haspopup="menu". This describes the menu it opens and excludes it from ComposerControl's active press scale, matching the other popup triggers. The change applies to web and desktop, which share this component.Scope and approval
This is a small, focused fix for an obvious visual bug in an existing menu trigger. It adds the missing popup semantics without changing permission behavior.
Verification
Before:
permissions-before.mov
After:
permissions-after.mov
vp run check:changed upstream/mainpassed formatting, lint, both knip checks, and affected typechecks.aria-haspopup.Model: gpt-6.1-sol. Harness: Codex in T3 Code.