Skip to content

fix(web): prevent permissions label from shrinking on click - #26470

Open
UtkarshUsername wants to merge 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/permissions-trigger-jump
Open

UtkarshUsername wants to merge 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/permissions-trigger-jump

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem

On the new thread page, pressing the permissions label below the composer briefly shrinks it, making the text appear to jump as the permissions menu opens.

Change

Mark the permissions button with aria-haspopup="menu". This describes the menu it opens and excludes it from ComposerControl's active press scale, matching the other popup triggers. The change applies to web and desktop, which share this component.

Scope and approval

This is a small, focused fix for an obvious visual bug in an existing menu trigger. It adds the missing popup semantics without changing permission behavior.

Verification

Before:

permissions-before.mov

After:

permissions-after.mov
  • vp run check:changed upstream/main passed formatting, lint, both knip checks, and affected typechecks.
  • Source inspection confirms the active scale selector excludes buttons with aria-haspopup.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 28, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5d77b21

Macroscope's review found this PR approvable — Adds menu-popup semantics to the permissions button, which also excludes it from the existing press-shrink animation. Permission behavior and product defaults remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 5211acf and 5d77b21.

Files selected for processing: 1
  • apps/web/src/components/ComposerContextPermissions.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The permissions control now sets aria-haspopup="menu".

Changes: Permissions menu semantics

Layer / File(s) Summary
Declare menu behavior
apps/web/src/components/ComposerContextPermissions.tsx
The permissions control now declares that it opens a menu using aria-haspopup="menu".

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

  • pingdotgg/t3code#25869: Adds the ComposerControl selector that excludes controls with aria-haspopup; this change adds that attribute to the permissions control.

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 5d77b

The change adds menu semantics to the permissions control without an identified behavior or permission regression.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary visual fix: preventing the permissions label from shrinking when clicked.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the visual bug, identifies the fix and scope, provides before and after evidence, and …
Full details: Description check

Explanation

The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the visual bug, identifies the fix and scope, provides before and after evidence, and lists validation results. It does not explicitly state that browser verification was not run, but the description is otherwise complete.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant