Skip to content

fix(desktop): Linux update message tells AUR users how to update - #28772

Open
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m164
Open

only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m164

Conversation

@only21mil

Copy link
Copy Markdown
Contributor

Problem

On Linux, Settings > About says "Automatic updates on Linux require the AppImage or the .deb package." when the app is packaged but has neither $APPIMAGE nor the .deb marker. The AUR packages hit this case: their PKGBUILDs download the official AppImage, extract it, and launch the extracted payload. So AUR users read that they need the AppImage, when the AppImage is exactly what they installed. The message doesn't tell them what to do instead.

Change

Only that one reason string changes. It now says that automatic updates work only for the AppImage and .deb downloads, and that other installs, such as AUR packages, update with the tool that installed them.

The code still checks the same two signals, $APPIMAGE and the .deb package-type marker. The new text names AUR packages only as an example, so it makes no claim the code can't back up. Update enablement and every other disabled reason stay the same.

Scope and approval

This is a very small fix for misleading copy, with no behavior change, so it qualifies without a prior issue. I kept it to the copy and added no package detection. #13178 had per-package-manager messages and was folded into #13177, and #13575 replaced that PR and shipped without them.

Verification

Before: the AUR t3code-nightly-bin package (0.1.6-nightly.20261031.3977), opened as a separate instance with fresh, isolated app data. I clicked Settings, then About.

Settings > About on the AUR nightly package showing the old Linux update message

After: this branch built with node scripts/build-desktop-artifact.ts --platform linux --target dir --arch x64. I added the AUR package's app-update.yml to resources/, since a dir build doesn't write one, then launched linux-unpacked the same way: no $APPIMAGE and no package-type marker, like the AUR install. I clicked Settings, then About.

Settings > About on this branch's build showing the new Linux update message

  • vp test run src/updates/DesktopUpdates.test.ts in apps/desktop: 35 passed. The existing Linux case still shows .deb installs as enabled and unmarked installs as disabled.
  • vp run check:changed 1d626d02d95f9a2343553f6498037ee82290d304: format, lint, knip, typecheck and tests pass.

I didn't add a test, because AGENTS.md says to leave out tests for copy text. The captures are the proof.

Not checked:

  • A real .deb or standalone AppImage launch. Neither can reach this string, and the code that enables them is unchanged.
  • Other non-AppImage Linux installs, such as Nix or a manual unpack. They get the same string, and I checked the wording only by reading it.
  • Mobile and web-only clients. They have no desktop updater.

Prior PRs

Generated with Claude Opus 5.5 and GPT-6.1 Sol in T3 Code Nightly

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 1, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d910ce2

Macroscope's review found this PR approvable — Clarifies the Linux update message so AUR and other package users know to update using their installation tool. Automatic-update eligibility and behavior are unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 3fd2b85 and d910ce2.

Files selected for processing: 1
  • apps/desktop/src/updates/DesktopUpdates.ts

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The Linux automatic-update disabled reason now specifies that automatic updates support AppImage and .deb downloads. It advises other installations, including AUR packages, to use their installation tool. The eligibility condition is unchanged.

Changes: Linux update notice

Layer / File(s) Summary
Update eligibility message
apps/desktop/src/updates/DesktopUpdates.ts
When Linux is detected without an AppImage or .deb package, the disabled reason now directs users to update other installations with their installation tool.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to d910c

No actionable merge-blocking risk remains in this copy-only update.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the Linux update message change for AUR users.
Description check Passed The description includes the problem, change, scope rationale, verification steps, test results, screenshots, and unchecked cases. It follows the required template and is specific to the pull request.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant