Skip to content

Support symfony/cache 8 and fix Static Analysis CI - #36

Merged
koriym merged 2 commits into
1.xfrom
symfony-8
Oct 28, 2026
Merged

koriym merged 2 commits into
1.xfrom
symfony-8

Conversation

@koriym

@koriym koriym commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Allow symfony/cache 8 (^6.0 || ^7.2 || ^8.0), so applications on Symfony 8 can install this module. BEAR.QueryRepository 1.18.0 needs this release to support Symfony 8.

Verification:

  • PHP 8.4 + symfony/cache 8.1.9: 23 tests pass with Redis and Memcached running; composer sa and composer cs clean.
  • PHP 8.2 + symfony/cache 8.1.9 (what CI's highest job resolves with --ignore-platform-req=php): 23 tests pass.
  • Every Symfony class used in src exists in symfony/cache 8.
  • BEAR.QueryRepository resolved against this branch as a path repository: 480 tests pass on symfony/cache 8.1.9.

Also includes 73c080f: removes the undeclared php_version input this repo's
static-analysis.yml was passing to static-analysis.yml@v2 (which only
declares has_crc_config). That mismatch made the Static Analysis check
fail at startup on every push since 2026-04-25, including 1.x and the
1.5.2 tag, so PHPStan/Psalm/PHPMD/composer-require-checker never actually
ran in CI. Folded into this PR (superseding a separate #37) so the
symfony/cache 8 change itself gets real static-analysis coverage before
merge, not just test coverage.

Summary by CodeRabbit

  • Compatibility
    • Applications running PHP 8.4 or later can now use this module with symfony/cache 8, alongside supported versions 6 and 7.2.
  • Documentation
    • The unreleased changelog now records the added compatibility with symfony/cache 8 and the PHP 8.4-or-later requirement for Symfony 8 applications. This clarifies which platform versions are supported when installing the module.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b463806a-a87d-43c0-ae7d-4c602998a2e0
Commits

Reviewing files that changed from the base of the PR and between 0855dd3 and 73c080f.

Files selected for processing: 1
  • .github/workflows/static-analysis.yml

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b6fda30e-1531-45c1-aeb1-4af1114dbe0d
Commits

Reviewing files that changed from the base of the PR and between 79bf260 and 0855dd3.

Files selected for processing: 2
  • CHANGELOG.md
  • composer.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Composer requirement now allows symfony/cache versions ^6.0, ^7.2, and ^8.0. The Unreleased changelog records Symfony Cache 8 support on PHP 8.4 or later.

Changes: Symfony Cache 8 Compatibility

Layer / File(s) Summary
Declare Symfony Cache 8 support
composer.json, CHANGELOG.md
The Composer constraint adds ^8.0 for symfony/cache. The Unreleased changelog records support on PHP 8.4 or later.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: Minimal · previous review 0855d

This change lets applications on Symfony 8 install the module. Installs on PHP 8.2 and 8.3 keep resolving a compatible symfony/cache 7.x release. No merge-blocking risk remains.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the main change: support for symfony/cache 8. The Static Analysis CI reference is not shown in the changeset, but it does not prevent the title from describing the primary…
Full details: Title check

Explanation

The title clearly identifies the main change: support for symfony/cache 8. The Static Analysis CI reference is not shown in the changeset, but it does not prevent the title from describing the primary change.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (79bf260) to head (73c080f).

Additional details and impacted files
@@             Coverage Diff             @@
##                 1.x       #36   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        38        38           
===========================================
  Files             24        24           
  Lines             90        90           
===========================================
  Hits              90        90           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koriym koriym changed the title Support symfony/cache 8 Support symfony/cache 8 and fix Static Analysis CI Oct 28, 2026
@koriym

koriym commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@koriym
koriym merged commit 0a7db3a into 1.x Oct 28, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant