Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Declare Symfony Cache 8 support composer.json, CHANGELOG.md |
The Composer constraint adds ^8.0 for symfony/cache. The Unreleased changelog records support on PHP 8.4 or later. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Feature
Merge Risk: 
Minimal · previous review 0855d
-
This change lets applications on Symfony 8 install the module. Installs on PHP 8.2 and 8.3 keep resolving a compatible symfony/cache 7.x release. No merge-blocking risk remains.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title clearly identifies the main change: support for symfony/cache 8. The Static Analysis CI reference is not shown in the changeset, but it does not prevent the title from describing the primary change.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #36 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 38 38
===========================================
Files 24 24
Lines 90 90
===========================================
Hits 90 90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
Allow
symfony/cache8 (^6.0 || ^7.2 || ^8.0), so applications on Symfony 8 can install this module. BEAR.QueryRepository 1.18.0 needs this release to support Symfony 8.Verification:
composer saandcomposer csclean.highestjob resolves with--ignore-platform-req=php): 23 tests pass.srcexists in symfony/cache 8.Also includes 73c080f: removes the undeclared
php_versioninput this repo'sstatic-analysis.ymlwas passing tostatic-analysis.yml@v2(which onlydeclares
has_crc_config). That mismatch made theStatic Analysischeckfail at startup on every push since 2026-04-25, including
1.xand the1.5.2tag, so PHPStan/Psalm/PHPMD/composer-require-checker never actuallyran in CI. Folded into this PR (superseding a separate #37) so the
symfony/cache 8 change itself gets real static-analysis coverage before
merge, not just test coverage.
Summary by CodeRabbit
symfony/cache8, alongside supported versions 6 and 7.2.symfony/cache8 and the PHP 8.4-or-later requirement for Symfony 8 applications. This clarifies which platform versions are supported when installing the module.