Skip to content

Fix startup_failure in Static Analysis workflow - #37

Closed
koriym wants to merge 1 commit into
1.xfrom
fix-static-analysis-workflow
Closed

koriym wants to merge 1 commit into
1.xfrom
fix-static-analysis-workflow

Conversation

@koriym

@koriym koriym commented Oct 28, 2026

Copy link
Copy Markdown
Member

static-analysis.yml@v2's workflow_call.inputs only declares has_crc_config; this repo's .github/workflows/static-analysis.yml was also passing php_version: 8.4, an undeclared input. GitHub Actions rejects the input at startup, so the Static Analysis check has been startup_failure on every push and PR since 2026-04-25 (including the 1.x branch and the 1.5.2 tag) — PHPStan, Psalm, PHPMD and composer-require-checker have not actually run in CI since then.

Fix: drop the undeclared php_version input (the reusable workflow fixes PHP at 8.3 internally). has_crc_config: true is unchanged.

Verification: ran the same four jobs v2 runs (PHPStan, Psalm, PHPMD, composer-require-checker) locally on PHP 8.3 against this branch's content — all four clean, no errors.

Unrelated to #36; same underlying breakage affects 1.x regardless of that PR.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b7f69e38-9a17-4069-8816-98ff01495c39
Commits

Reviewing files that changed from the base of the PR and between 79bf260 and 9bb7ed5.

Files selected for processing: 1
  • .github/workflows/static-analysis.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (79bf260) to head (9bb7ed5).

Additional details and impacted files
@@             Coverage Diff             @@
##                 1.x       #37   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        38        38           
===========================================
  Files             24        24           
  Lines             90        90           
===========================================
  Hits              90        90           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koriym

koriym commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

Folded into #36 (73c080f) so that PR's own Static Analysis check gets real coverage before merge, instead of merging #36 unverified and fixing CI separately afterward. Closing this one.

@koriym koriym closed this Oct 28, 2026
@koriym
koriym deleted the fix-static-analysis-workflow branch October 28, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant