Repository navigation
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #37 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 38 38
===========================================
Files 24 24
Lines 90 90
===========================================
Hits 90 90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static-analysis.yml@v2'sworkflow_call.inputsonly declareshas_crc_config; this repo's.github/workflows/static-analysis.ymlwas also passingphp_version: 8.4, an undeclared input. GitHub Actions rejects the input at startup, so theStatic Analysischeck has beenstartup_failureon every push and PR since 2026-04-25 (including the1.xbranch and the1.5.2tag) — PHPStan, Psalm, PHPMD and composer-require-checker have not actually run in CI since then.Fix: drop the undeclared
php_versioninput (the reusable workflow fixes PHP at 8.3 internally).has_crc_config: trueis unchanged.Verification: ran the same four jobs v2 runs (PHPStan, Psalm, PHPMD, composer-require-checker) locally on PHP 8.3 against this branch's content — all four clean, no errors.
Unrelated to #36; same underlying breakage affects
1.xregardless of that PR.