Skip to content

chore(deps): bump github.com/onsi/ginkgo/v2 from 2.32.0 to 2.33.1 in /argocd-operator - #1389

Closed
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/argocd-operator/master/github.com/onsi/ginkgo/v2-2.33.1
Closed

dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/argocd-operator/master/github.com/onsi/ginkgo/v2-2.33.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps github.com/onsi/ginkgo/v2 from 2.32.0 to 2.33.1.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.33.1

Fixes

  • Add several missing fields to spec report JSON output.

v2.33.0

Features

  • The JUnit reporter now records each spec's ReportEntrys as <properties> on its <testcase> element, with the entry's name and its JSON-encoded value. Thanks @​pohly! [23db51a]

Maintenance

  • Releases are now cut by a GitHub Actions workflow (Actions -> Release -> Run workflow) rather than by hand, with changelog entries collected under ## Unreleased as the work happens. See RELEASING.md. [8616ecb]

v2.32.2

2.32.2

Fixes

  • fix bug where ginkgo -race -p was taking extra long to exit [c6792b0]

v2.32.1

2.32.1

Fixes

  • Defer AfterAll until repeated spec completes [e647b3b]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.33.1

Fixes

  • Add several missing fields to spec report JSON output.

2.33.0

Features

  • The JUnit reporter now records each spec's ReportEntrys as <properties> on its <testcase> element, with the entry's name and its JSON-encoded value. Thanks @​pohly! [23db51a]

Maintenance

  • Releases are now cut by a GitHub Actions workflow (Actions -> Release -> Run workflow) rather than by hand, with changelog entries collected under ## Unreleased as the work happens. See RELEASING.md. [8616ecb]

2.32.2

Fixes

  • fix bug where ginkgo -race -p was taking extra long to exit [c6792b0]

2.32.1

Fixes

  • Defer AfterAll until repeated spec completes [e647b3b]
Commits
  • 7ff96d7 v2.33.1
  • 699632a Precompile the fixture in the suite-timeout integration test (#1689)
  • 9e02cad ci: default the release bump so a mobile dispatch can't send it empty (#1688)
  • ef6a46c Update CHANGELOG.md
  • 6c652a2 Add missing fields to SpecReport JSON marshalling, and add unit test
  • 510c8d5 Update TestMu AI sponsor logo and link
  • 5c1e7ef Refer sanitizer help to go help build
  • 9f94149 v2.33.0
  • db78e1b changelog: entries for the JUnit ReportEntry support and the release flow
  • 8616ecb ci: release from a single workflow_dispatch button
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Oct 13, 2026
@openshift-ci
openshift-ci Bot requested review from Rizwana777 and jparsai October 13, 2026 08:15
@openshift-ci

openshift-ci Bot commented Oct 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olivergondza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 4204e0a3-e33e-493e-abf3-919c7945791d
📥 Commits

Reviewing files that changed from the base of the PR and between 181d429 and ab18b59.

⛔ Files ignored due to path filters: 1
  • argocd-operator/go.sum is excluded by !**/*.sum
📒 Files selected for processing: 1
  • argocd-operator/go.mod
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the project’s testing tooling and supporting configuration. These maintenance changes do not alter the app’s user-facing features or behavior.

The operator module updates Ginkgo from v2.32.0 to v2.33.1 and revises its indirect dependency list.

Changes: Operator module dependencies

Layer / File(s) Summary
Update module dependencies
argocd-operator/go.mod
Ginkgo changes from v2.32.0 to v2.33.1, and Zap v1.28.0 is marked indirect. The indirect dependency list removes and adds the packages summarized above.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: olivergondza

Merge Risk: ⚪ Minimal · up to ab18b

This updates the operator’s Ginkgo test dependency and prunes indirect requirements. No concrete user or deployment risk is evident; the change is ready to merge after normal checks.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Title check Passed The title clearly identifies the dependency, version change, and affected directory.
Description check Passed The description directly explains the Ginkgo upgrade and summarizes its release notes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR

@openshift-ci

openshift-ci Bot commented Oct 13, 2026

Copy link
Copy Markdown

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ranakan19

Copy link
Copy Markdown
Contributor

/ok-to-test

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.32.0 to 2.33.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.32.0...v2.33.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.33.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/go_modules/argocd-operator/master/github.com/onsi/ginkgo/v2-2.33.1 branch from 181d429 to ab18b59 Compare October 14, 2026 06:49
@jgwest

jgwest commented Oct 14, 2026

Copy link
Copy Markdown
Member

/retest

@openshift-ci

openshift-ci Bot commented Oct 14, 2026

Copy link
Copy Markdown

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit ab18b59 link true /test unit
ci/prow/v4.19-e2e ab18b59 link true /test v4.19-e2e
ci/prow/v4.19-kuttl-sequential ab18b59 link true /test v4.19-kuttl-sequential
ci/prow/v4.19-kuttl-parallel ab18b59 link true /test v4.19-kuttl-parallel
ci/prow/v4.14-e2e ab18b59 link false /test v4.14-e2e
ci/prow/v4.14-kuttl-parallel ab18b59 link false /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential ab18b59 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ranakan19

Copy link
Copy Markdown
Contributor

checks for this PR won't pass without grouping sub modules go.mod updates in the same PR as main module go.mod
and this is being ignored from dependabot updates in #1402
thus closing this

@ranakan19 ranakan19 closed this Oct 15, 2026
@dependabot @github

dependabot Bot commented on behalf of github Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code ok-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants