Skip to content

chore: add test frameworks to dependabot ignore list - #1402

Merged
jgwest merged 1 commit into
redhat-developer:masterfrom
jgwest:add-test-frameworks-to-ignore-list-oct-2026
Oct 15, 2026
Merged

jgwest merged 1 commit into
redhat-developer:masterfrom
jgwest:add-test-frameworks-to-ignore-list-oct-2026

Conversation

@jgwest

@jgwest jgwest commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

There is no purpose to remaining doggedly up to date with test framework versions:

  • We don't ship them or our tests, so there are no security concerns.
  • We largely don't take advantage of new features from these frameworks.
  • If we need a new feature, we can easily update manually.

PR acceptance criteria:

  • Documentation was updated and verified using make serve-docs
  • Unit tests were updated
  • E2E tests were updated

What type of PR is this?

/kind cleanup

Special notes to the reviewer:

Signed-off-by: Jonathan West <jgwest@gmail.com>
@openshift-ci openshift-ci Bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process. label Oct 15, 2026
@openshift-ci
openshift-ci Bot requested review from jannfis and trdoyle81 October 15, 2026 01:36
@openshift-ci

openshift-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adamsaleh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 3867c328-626c-4eb8-9ea3-1e43833480aa
📥 Commits

Reviewing files that changed from the base of the PR and between 8dbdac7 and 2b80a82.

📒 Files selected for processing: 1
  • .github/dependabot.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Automated weekly Go dependency updates for the listed Go versions and master now skip updates to three test libraries.

Dependabot’s weekly Go module update entries for v1.20, v1.21, v1.22, and master now ignore updates to three specified dependencies.

Changes: Dependabot update rules

Layer / File(s) Summary
Add dependency ignore rules
.github/dependabot.yml
The four weekly update entries now ignore github.com/stretchr/testify, github.com/onsi/gomega, and github.com/onsi/ginkgo/v2.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: ranakan19

Merge Risk: ⚪ Minimal · up to 2b80a

These rules suppress updates for the specified test frameworks, while the inspected nested test setup is outside the production entrypoint’s import graph. No merge-blocking risk is established.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: adding test frameworks to the Dependabot ignore list.
Description check Passed The description explains why the test frameworks should be ignored and matches the Dependabot configuration changes.

Comment @coderabbitai help to get the list of available commands.

@ranakan19 ranakan19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@openshift-ci

openshift-ci Bot commented Oct 15, 2026

Copy link
Copy Markdown

@jgwest: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 2b80a82 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgwest

jgwest commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

/retest

@jgwest

jgwest commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Merging as @ranakan19 has approved, and no need for green CI on a non-code change.

@jgwest
jgwest merged commit a7cb991 into redhat-developer:master Oct 15, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process. lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants