Source school-district chart from affiliation address - #2534
Merged
Merged
Conversation
The registrant school-district breakdown read each person's own home address, but a school district describes the institution someone facilitates at — the org address on their affiliation, not their home. Re-sources the chart, its filter chip, and the drill-in from Affiliation#organization_address (active as of the event), counting a registrant once per district they're affiliated with. Relabels the address "District" field to "School district" everywhere it appears. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The attendees drill-in filtered on any affiliation pointing at the district address; scope it to affiliations active today so an ended affiliation can't appear in the list without being in the chart count. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
September 11, 2026 15:42
Scope the school-district breakdown to the affiliation tied to each event registration (the org the person registered under), not every affiliation the person holds. Because the source is now registration-scoped it needs no active-as-of date: the drill-in filter matches on event_registration_id too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jmilljr24
approved these changes
Sep 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 contained re-source of one breakdown + label change, covered by service/request specs
Re-sources the registrant "School districts" breakdown from the affiliation linked to each event registration (the org the person registered under) instead of their personal home address — a school district describes the institution someone facilitates at, not where they live.
What changes
school_district_*now reads the affiliations linked to the event's registrations (Affiliation#event_registration_id) →organization_address→Address#district, in both the single-event dashboard and the cross-event attendees breakdowns. Only the org each registrant registered under counts — not every affiliation the person holds.school_districtdrill-in and chip resolve people the same way (affiliation scoped to the in-scope registrations), so the list matches the chart. No as-of date needed: registration-scoping is inherently event-bounded.district(a rename is a data migration touching ~15 files for no user-facing gain; the app's param/chip/title vocab is alreadyschool_district).Notes for the reviewer