Repository navigation
Fix supporting fluid check for striders - #1598
Open
Nobodiiiii wants to merge 1 commit into
Open
Nobodiiiii wants to merge 1 commit into
Nobodiiiii wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla striders lose their lava-surface collision support and move slowly with repeated stuttering when Sable is installed.
LiquidBlock.getCollisionShapepasses the fluid above the block as the first argument and the supporting fluid as the second argument tocanStandOnFluid. Sable checks the first argument, so air above lava causes the capability check to fail.Check
fluidState2, matching vanillaEntityCollisionContext. This restores the lava support shape and prevents striders from repeatedly sinking into the buoyancy branch that halves their velocity. The change is limited to one argument; movement speed and buoyancy are unchanged.Fixes #305.
Related reports: #811, #1285, #1389.
Validation