Repository navigation
feat(upload): link failing tests by GUID when only the quarantine lookup named the collection - #1295
Open
acatxnamedvirtue wants to merge 1 commit into
Open
acatxnamedvirtue wants to merge 1 commit into
acatxnamedvirtue wants to merge 1 commit into
Conversation
…kup named the collection The failing-tests table built its GUID links only from the upload's ids. A dry run or a failed upload has none, so it fell back to the `/t/<id>?repo=` short link even when the v2 quarantine lookup had already returned the collection uuid and repository id. The run now uses the lookup's pair when the upload gives none. Also pins ADR-0019's `--no-repo` golden vector at the URL layer. Part of TRUNK-21084 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing-tests table in the upload summary (text, JSON and GitHub output) links each test to
{app}/{org}/flaky-tests/collections/{shortId}/tests/{guid}. The guid is the ADR-0019 test-case GUID, computed in-process withgen_test_case_guidfrom the collection uuid, the repository id and the test's id. Until now the table took that pair only from the upload response. A failed upload, or a dry run on v2, has no upload ids, so the table fell back to the/t/<id>?repo=short link, even when the v2 quarantine lookup had already returned the sametestCollectionUuidandrepositoryId.Most of TRUNK-21084 already landed in #1196 (GUID collection links) and #1256 (v2 upload and quarantine). This closes the remaining gap.
What changes
QuarantineContextkeeps the quarantine lookup's ids.What does not change
/flaky-tests/test/<id>?repo=link, and a run with a collection but no ids from either response keeps the short link. TRUNK-23150 removes the repo-only paths separately.--dry-run(which never asks for the API version), keep the short link. Changing that means moving the version call, which feat(cli): upload fork PRs on v2 by swapping the job's GITHUB_TOKEN #1293 is reworking.Tests
--no-repogolden vector (943a80af-66b0-84bb-ad01-56b3b72fe363) next to the existing with-repo vector. Both matchcontext/src/meta/id.rs, the bindings and trunk2's ingest contract test.Part of TRUNK-21084
🤖 Generated with Claude Code