Repository navigation
feat(cli)!: require --test-collection-id and remove the repo lane - #1298
Open
acatxnamedvirtue wants to merge 1 commit into
Open
acatxnamedvirtue wants to merge 1 commit into
acatxnamedvirtue wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
analytics-cli 1.0.0 uploads only to test collections. - `--test-collection-id` / `TRUNK_TEST_COLLECTION_ID` is required for `upload` and `test`; a blank value counts as missing. `run_upload` also refuses a run without one, for the test-runner plugins. - The rspec gem stays off, with a warning, when `TRUNK_TEST_COLLECTION_ID` is unset or blank; the native plugin makes no quarantine lookup and no upload without it. - `--public-repo-id` / `TRUNK_PUBLIC_REPO_ID` and its `x-trunk-public-repo-id` header are gone. `--allow-forked-pr-uploads` stays. - `--hide-test-collection-links` / `TRUNK_HIDE_TEST_COLLECTION_LINKS` and the repo-scoped `/flaky-tests/test/<id>` link are gone. - Smoke tests name a collection on every run, and the public repo id steps use the collection fork lane instead. Part of TRUNK-23150 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
acatxnamedvirtue
force-pushed
the
tylerbeebe/trunk-23150-analytics-cli-100-require-test
branch
from
November 9, 2026 17:47
ba2f8a0 to
5f51616
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analytics-cli 1.0.0 uploads only to test collections. Every org is on them now (TRUNK-21074).
Breaking changes
--test-collection-id(TRUNK_TEST_COLLECTION_ID) is required foruploadandtest; a blank value counts as missing. The rspec gem stays off, with a warning, withoutTRUNK_TEST_COLLECTION_ID. The test-runner plugin makes no quarantine lookup and no upload without it.--public-repo-id(TRUNK_PUBLIC_REPO_ID) and itsx-trunk-public-repo-idheader are removed. Forked pull requests use--allow-forked-pr-uploads, which stays.--tokenis required unless--allow-forked-pr-uploadsis passed.--hide-test-collection-links(TRUNK_HIDE_TEST_COLLECTION_LINKS) and repo-scoped test links (/flaky-tests/test/<id>) are removed. Links always point into the collection.CI
--allow-forked-pr-uploadswith4B2wfoEU(production) andz2dzjLHm(staging). Both collections have forked-PR uploads enabled (confirmed 2026-11-09).continue-on-error, so a failure failsperform_smoke_test, which gates release promotion.Not in this PR: removing the v1/v2 decision call and the collection inference, which no CLI run can reach now (TRUNK-23148).
Conflicts: #1293 (fork lane on v2) touches
api/src/client/mod.rs,cli/src/upload_command.rs,cli/tests/common/command_builder.rsandcli/tests/upload.rs; whichever merges second rebases. #1295 also editsapi/src/urls.rs.Tests
upload,test, blank values),--public-repo-idbeing gone, a token or--allow-forked-pr-uploadsbeing required, the plugin making no calls without a collection, and the gem staying off (test/test_collection_spec.rb).cargo nextest run --workspace: 593 of 596 pass; the 3 failures are Swift xunit tests that need a Swift language server. The gem specs were not run locally (the native extension doesn't compile on the dev box), so CI is their first run.Part of TRUNK-23150
🤖 Generated with Claude Code