Repository navigation
fix(web): left sidebar no longer slides under the toggle - #16
Closed
Claudesaul wants to merge 1 commit into
Closed
Claudesaul wants to merge 1 commit into
Claudesaul wants to merge 1 commit into
Conversation
… toggle when it closes
Owner
Author
|
Opened upstream as pingdotgg#26315. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the left sidebar closes with panel animations on, everything in it slides left under the sidebar toggle. The "T3 Code" title passes right under the toggle button. Same bug as pingdotgg#26233, on the other side.
Change
The sidebar's content now stays where it is, and the sidebar's right edge sweeps left over it, like a curtain closing. Opening does the reverse. The resize handle still works.
Scope and approval
A small change in the shared
Sidebar(ui/sidebar.tsx): offcanvas collapse clips the sidebar instead of moving it off screen. That changes how the close animation looks, so it may need a maintainer's call.Verification
Sidebarbrowser tests pass.vp run dev(dark mode, 300ms panel animation) and stepped the close and open animations frame by frame, before and after. The open sidebar is pixel-identical, and dragging the edge still resizes it. Not checked in the Electron window.Recording, slowed down for one close and frozen 20ms in:
Model: Claude Opus 5.5. Harness: Claude Code through T3 Code.