Repository navigation
fix(web): left sidebar no longer slides under the toggle - #26315
Claudesaul wants to merge 1 commit into
Conversation
… toggle when it closes
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Desktop sidebars now clip closed in place instead of sliding beneath the title-bar controls. The change is limited to presentation, with mobile behavior and existing collapse interaction safeguards unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Sidebar clipping transition apps/web/src/components/ui/sidebar.tsx |
The left and right variants clip the open sidebar at the rail-side inset and fully clip it when offcanvas-collapsed. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix · Severity of issue fixed: Low
Possibly related PRs
- pingdotgg/t3code#25464: Introduced the desktop sidebar offcanvas and resize implementation that this change modifies.
Suggested labels: bugfix, size:S
Suggested reviewers: juliusmarminge, t3dotgg
Merge Risk: 
Minimal · up to 01cd5
-
No actionable merge-blocking risk was identified in the sidebar transition change.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title names the main change: the left sidebar no longer slides under the toggle. It uses the conventional commit format and matches the summary and objectives, which describe clipping the sidebar instead of moving it off screen on offcanvas collapse. The title is 56 characters and 9 words, which is slightly long but still clear.
Full details: Description check
-
Explanation
The description follows the template. It has Problem, Change, Scope and approval, and Verification sections, and each section has real content. The Problem section gives the behavior and a reproduction context (panel animations on, dark mode, 300ms). The Change section explains the clip-path fix. The Scope section names the shared Sidebar file and flags that a maintainer may need to decide. The Verification section lists lint, format, and browser tests, plus manual frame-by-frame checks. It also states what was not checked (Electron window). The description also includes the required model and harness line and a before/after recording. Gaps: the Scope section does not link a triaged issue or a maintainer approval comment, and it does not explain why the change qualifies without prior approval. The Verification section cites test results but not the exact test names or counts. The before/after evidence is a recording and does not include a static before/after screenshot set.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Problem
When the left sidebar closes with panel animations on, everything in it slides left under the sidebar toggle. The "T3 Code" title passes right under the toggle button.
Change
The sidebar's content now stays where it is, and the sidebar's right edge sweeps left over it, like a curtain closing. Opening does the reverse. The resize handle still works.
Scope and approval
A small change in the shared
Sidebar(ui/sidebar.tsx): offcanvas collapse clips the sidebar instead of moving it off screen. That changes how the close animation looks, so it may need a maintainer's call.Verification
Sidebarbrowser tests pass.vp run dev(dark mode, 300ms panel animation) and stepped the close and open animations frame by frame, before and after. The open sidebar is pixel-identical, and dragging the edge still resizes it. Not checked in the Electron window.Recording, slowed down for one close and frozen 20ms in:
Goes with #26232 and #26233: same title bar cleanup, on the left sidebar.
Model: Claude Opus 5.5. Harness: Claude Code through T3 Code.