You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
getPotionById/getIdFromPotion and co. should not be changed without associated changes in Blocks/Items/all other registry entry classes. The pattern is pretty clear and consistent.
I'll see about collecting these sorts of changes in a single (meta) issue then, maybe? I've already suggested changing the item/block ones in #524/#521.
removeAttributeModifiers and applyAttributeModifiers are more accurately described as endEffect and beginEffect, since they aren't solely used for attributes.
Activity
williewillus commentedon Sep 27, 2017
getPotionById/getIdFromPotion and co. should not be changed without associated changes in Blocks/Items/all other registry entry classes. The pattern is pretty clear and consistent.
marvin-roesch commentedon Sep 27, 2017
I'll see about collecting these sorts of changes in a single (meta) issue then, maybe? I've already suggested changing the item/block ones in #524/#521.
kashike commentedon Sep 5, 2018
func_82720_e:getIsAmbient→isAmbientfunc_82719_a:writeCustomPotionEffectToNBT→writefunc_82722_b:readCustomPotionEffectFromNBT→readfield_82724_e:isAmbient→ambientyrsegal commentedon Nov 28, 2018
removeAttributeModifiersandapplyAttributeModifiersare more accurately described asendEffectandbeginEffect, since they aren't solely used for attributes.ChloeDawn commentedon Nov 28, 2018
func_193076_bZ:getActivePotionMap->getActivePotions