You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think this is a good idea. MCP names don't rely as heavily on Mob as mojang names, so it would be very inconsistent to push for the use of MobEffect here. If anything, MobEffects should change to Potions and the rest should be left alone.
@Shadows-of-Fire It is true we don't have Mob as apart of entity hierarchy as it actually is, but developers knows what mobs are in the context of the game, and there are many locations where we do actually reference "mob" in code.
Potions, as named currently is wildly inaccurate. Our PotionTypes are the actual potions and the Potion we have is not about potions, but instead merely the representation of an effect applied to mobs, and only some are for potions, others are applied by other game mechanics. These class renames are certainly warranted.
Activity
Shadows-of-Fire commentedon Sep 2, 2018
I don't think this is a good idea. MCP names don't rely as heavily on
Mobas mojang names, so it would be very inconsistent to push for the use ofMobEffecthere. If anything,MobEffectsshould change toPotionsand the rest should be left alone.pau101 commentedon Sep 2, 2018
@Shadows-of-Fire It is true we don't have
Mobas apart of entity hierarchy as it actually is, but developers knows what mobs are in the context of the game, and there are many locations where we do actually reference "mob" in code.Potions, as named currently is wildly inaccurate. OurPotionTypesare the actual potions and thePotionwe have is not about potions, but instead merely the representation of an effect applied to mobs, and only some are for potions, others are applied by other game mechanics. These class renames are certainly warranted.kashike commentedon Aug 26, 2020
Issues regarding class and package names are now handled in the MCPConfig repository.